Changeset 90105 in webkit

Timestamp:

Jun 30, 2011 4:19:40 AM (13 years ago)

Author:

loki@webkit.org

Message:

2011-06-30 Gabor Loki <​loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Fixed several style and typo issues after r90091.
​https://bugs.webkit.org/show_bug.cgi?id=63692

Rename yStart to extremaStartY during computing extremas

• platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApplyGeneric):
• platform/graphics/filters/FEMorphology.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/filters/FEMorphology.cpp (modified) (3 diffs)
• platform/graphics/filters/FEMorphology.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-30  Gabor Loki  <loki@webkit.org>
+
+        Reviewed by Csaba Osztrogonác.
+
+        Fixed several style and typo issues after r90091.
+        https://bugs.webkit.org/show_bug.cgi?id=63692
+
+        Rename yStart to extremaStartY during computing extremas
+
+        * platform/graphics/filters/FEMorphology.cpp:
+        (WebCore::FEMorphology::platformApplyGeneric):
+        * platform/graphics/filters/FEMorphology.h:
+
 2011-06-30  Oliver Varga  <Varga.Oliver@stud.u-szeged.hu>
 

trunk/Source/WebCore/platform/graphics/filters/FEMorphology.cpp

@@ -108 +108 @@
     const int width = paintingData->width;
     const int height = paintingData->height;
-    const int effectWidth  = width * 4;
+    const int effectWidth = width * 4;
     const int radiusX = paintingData->radiusX;
     const int radiusY = paintingData->radiusY;
@@ -120 +120 @@
             // Compute extremas for each columns
             for (int x = 0; x <= radiusX; ++x) {
-                unsigned char columnExtrema = srcPixelArray->get(yStart * effectWidth  + 4 * x + clrChannel);
+                unsigned char columnExtrema = srcPixelArray->get(extremaStartY * effectWidth + 4 * x + clrChannel);
                 for (int eY = extremaStartY + 1; eY < extremaEndY; ++eY) {
-                    unsigned char pixel = srcPixelArray->get(eY * effectWidth  + 4 * x + clrChannel);
+                    unsigned char pixel = srcPixelArray->get(eY * effectWidth + 4 * x + clrChannel);
                     if ((m_type == FEMORPHOLOGY_OPERATOR_ERODE && pixel <= columnExtrema)
                         || (m_type == FEMORPHOLOGY_OPERATOR_DILATE && pixel >= columnExtrema)) {
@@ -135 +135 @@
             for (int x = 0; x < width; ++x) {
                 const int endX = min(x + radiusX, width - 1);
-                unsigned char columnExtrema = srcPixelArray->get(extremaStartY * effectWidth  + endX * 4 + clrChannel);
+                unsigned char columnExtrema = srcPixelArray->get(extremaStartY * effectWidth + endX * 4 + clrChannel);
                 for (int i = extremaStartY + 1; i <= extremaEndY; ++i) {
-                    unsigned char pixel = srcPixelArray->get(i * effectWidth  + endX * 4 + clrChannel);
+                    unsigned char pixel = srcPixelArray->get(i * effectWidth + endX * 4 + clrChannel);
                     if ((m_type == FEMORPHOLOGY_OPERATOR_ERODE && pixel <= columnExtrema)
                         || (m_type == FEMORPHOLOGY_OPERATOR_DILATE && pixel >= columnExtrema))

trunk/Source/WebCore/platform/graphics/filters/FEMorphology.h

@@ -76 +76 @@
 #endif
 
-    void platformApply(PaintingData*);
+    inline void platformApply(PaintingData*);
     inline void platformApplyGeneric(PaintingData*, const int yStart, const int yEnd);
 private: