Changeset 90196 in webkit


Ignore:
Timestamp:
Jun 30, 2011 7:55:49 PM (13 years ago)
Author:
yutak@chromium.org
Message:

2011-06-30 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers
​https://bugs.webkit.org/show_bug.cgi?id=63704

  • http/tests/websocket/tests/bad-handshake-crash_wsh.py: Use handshake format of Hixie's protocol draft 76 which we are currently supporting.
  • http/tests/websocket/tests/long-invalid-header_wsh.py: Content of web_socket_transfer_data() is completely bogus. It's not necessary.
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r90195 r90196  
     12011-06-30  Yuta Kitamura  <yutak@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers
     6        https://bugs.webkit.org/show_bug.cgi?id=63704
     7
     8        * http/tests/websocket/tests/bad-handshake-crash_wsh.py:
     9        Use handshake format of Hixie's protocol draft 76 which we are currently supporting.
     10        * http/tests/websocket/tests/long-invalid-header_wsh.py:
     11        Content of web_socket_transfer_data() is completely bogus. It's not necessary.
     12
    1132011-06-30  Kent Tamura  <tkent@chromium.org>
    214

  • trunk/LayoutTests/http/tests/websocket/tests/bad-handshake-crash_wsh.py

    r90099 r90196  
    11def web_socket_do_extra_handshake(request):
    2     msg = "HTTP/1.1 101 Web Socket Protocol Handshake\r\n"
     2    msg = "HTTP/1.1 101 WebSocket Protocol Handshake\r\n"
    33    msg += "Upgrade: WebSocket\r\n"
    44    msg += "Connection: Upgrade\r\n"
     5    msg += "Sec-WebSocket-Location: " + request.ws_location + "\r\n"
     6    msg += "Sec-WebSocket-Origin: " + request.ws_origin + "\r\n"
    57    msg += "\xa5:\r\n"
    68    msg += "\r\n"
     9    msg += request.ws_challenge_md5
    710    request.connection.write(msg)
    811    print msg

  • trunk/LayoutTests/http/tests/websocket/tests/long-invalid-header_wsh.py

    r90099 r90196  
    11def web_socket_do_extra_handshake(request):
    2     msg = "HTTP/1.1 101 Web Socket Protocol Handshake\r\n"
     2    msg = "HTTP/1.1 101 WebSocket Protocol Handshake\r\n"
    33    msg += ("p" * 1024) + "\r\n"
    44    request.connection.write(msg)
    … …  
    66
    77def web_socket_transfer_data(request):
    8     msg = "HTTP/1.1 101 Web Socket Protocol Handshake\r\n"
    9     msg += ("p" * 1024) + "\r\n"
    10     request.connection.write(msg)
     8    pass
Note: See TracChangeset for help on using the changeset viewer.