Changeset 90275 in webkit
- Timestamp:
- Jul 1, 2011 2:07:39 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 43 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r90274 r90275 1 2011-07-01 Ryosuke Niwa <rniwa@webkit.org> 2 3 Reviewed by Ojan Vafai. 4 5 Move m_isDirectional from FrameSelection to VisibleSelection 6 https://bugs.webkit.org/show_bug.cgi?id=63473 7 8 Added a test to ensure WebKit preserves non-directional selection after undo on Mac. 9 10 The directionality of selection is still lost after undoing DeleteSelectionCommand or TypingCommand 11 and this will be fixed in follow up patches. 12 13 * editing/deleting/delete-br-011-expected.txt: 14 * editing/selection/after-line-break-expected.txt: 15 * editing/selection/anchor-focus2-expected.txt: 16 * editing/selection/anchor-focus3-expected.txt: 17 * editing/selection/directionality-after-undo-replace-expected.txt: Added. 18 * editing/selection/directionality-after-undo-replace.html: Added. 19 * platform/mac/editing/deleting/delete-br-002-expected.txt: 20 * platform/mac/editing/deleting/delete-br-004-expected.txt: 21 * platform/mac/editing/deleting/delete-br-005-expected.txt: 22 * platform/mac/editing/deleting/delete-br-006-expected.txt: 23 * platform/mac/editing/deleting/delete-br-009-expected.txt: 24 * platform/mac/editing/deleting/delete-br-010-expected.txt: 25 * platform/mac/editing/deleting/smart-delete-002-expected.txt: 26 * platform/mac/editing/inserting/insert-3800346-fix-expected.txt: 27 * platform/mac/editing/inserting/insert-at-end-01-expected.txt: 28 * platform/mac/editing/inserting/insert-at-end-02-expected.txt: 29 * platform/mac/editing/inserting/insert-div-010-expected.txt: 30 * platform/mac/editing/inserting/insert-div-013-expected.txt: 31 * platform/mac/editing/inserting/insert-div-015-expected.txt: 32 * platform/mac/editing/inserting/insert-div-019-expected.txt: 33 * platform/mac/editing/inserting/insert-paragraph-03-expected.txt: 34 * platform/mac/editing/pasteboard/3976872-expected.txt: 35 * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt: 36 * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt: 37 * platform/mac/editing/pasteboard/paste-text-014-expected.txt: 38 * platform/mac/editing/selection/4932260-1-expected.txt: 39 * platform/mac/editing/selection/expanding-selections-expected.txt: 40 * platform/mac/editing/selection/expanding-selections2-expected.txt: 41 * platform/mac/editing/selection/fake-drag-expected.txt: 42 * platform/mac/editing/selection/move-by-word-001-expected.txt: 43 * platform/mac/editing/selection/triple-click-in-pre-expected.txt: 44 * platform/mac/editing/style/create-block-for-style-008-expected.txt: 45 * platform/mac/editing/undo/4063751-expected.txt: 46 * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt: 47 * platform/mac/editing/undo/undo-forward-delete-expected.txt: 48 1 49 2011-07-01 Mihai Parparita <mihaip@chromium.org> 2 50 -
trunk/LayoutTests/editing/deleting/delete-br-011-expected.txt
r65208 r90275 1 1 EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of BODY > HTML > #document to 4 of BODY > HTML > #document 2 2 EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification 3 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 3 7 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -
trunk/LayoutTests/editing/selection/after-line-break-expected.txt
r81095 r90275 4 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 5 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 6 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document toDOMRange:range from 6 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 6 7 Test for rdar://problem/5973313 REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas. 7 8 -
trunk/LayoutTests/editing/selection/anchor-focus2-expected.txt
r81095 r90275 1 1 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 2 2 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 3 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 3 4 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 4 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -
trunk/LayoutTests/editing/selection/anchor-focus3-expected.txt
r81095 r90275 1 1 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 2 2 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 3 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 3 4 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 4 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt
r63291 r90275 25 25 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 26 26 EDITING DELEGATE: shouldDeleteDOMRange:range from 2 of SPAN > DIV > BODY > HTML > #document to 3 of SPAN > DIV > BODY > HTML > #document 27 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of SPAN > DIV > BODY > HTML > #document to 2 of SPAN > DIV > BODY > HTML > #document toDOMRange:range from 2 of SPAN > DIV > BODY > HTML > #document to 2 of SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 27 28 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 28 29 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.txt
r63291 r90275 26 26 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 27 27 EDITING DELEGATE: shouldDeleteDOMRange:range from 3 of SPAN > DIV > BODY > HTML > #document to 4 of SPAN > DIV > BODY > HTML > #document 28 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of SPAN > DIV > BODY > HTML > #document to 3 of SPAN > DIV > BODY > HTML > #document toDOMRange:range from 3 of SPAN > DIV > BODY > HTML > #document to 3 of SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 28 29 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 29 30 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-005-expected.txt
r63291 r90275 26 26 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 27 27 EDITING DELEGATE: shouldDeleteDOMRange:range from 3 of SPAN > DIV > BODY > HTML > #document to 4 of SPAN > DIV > BODY > HTML > #document 28 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of SPAN > DIV > BODY > HTML > #document to 3 of SPAN > DIV > BODY > HTML > #document toDOMRange:range from 3 of SPAN > DIV > BODY > HTML > #document to 3 of SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 28 29 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 29 30 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-006-expected.txt
r63291 r90275 26 26 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 27 27 EDITING DELEGATE: shouldDeleteDOMRange:range from 3 of SPAN > DIV > BODY > HTML > #document to 4 of SPAN > DIV > BODY > HTML > #document 28 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of SPAN > DIV > BODY > HTML > #document to 3 of SPAN > DIV > BODY > HTML > #document toDOMRange:range from 3 of SPAN > DIV > BODY > HTML > #document to 3 of SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 28 29 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 29 30 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-009-expected.txt
r63291 r90275 8 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 9 9 EDITING DELEGATE: shouldDeleteDOMRange:range from 2 of BODY > HTML > #document to 0 of DIV > BODY > HTML > #document 10 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 10 11 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 11 12 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-010-expected.txt
r63291 r90275 8 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 9 9 EDITING DELEGATE: shouldDeleteDOMRange:range from 2 of BODY > HTML > #document to 0 of DIV > BODY > HTML > #document 10 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 10 11 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 11 12 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/deleting/smart-delete-002-expected.txt
r81095 r90275 4 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 5 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > DIV > DIV > BODY > HTML > #document to 5 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > DIV > BODY > HTML > #document to 5 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 6 7 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > DIV > DIV > BODY > HTML > #document to 5 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > DIV > BODY > HTML > #document to 8 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 7 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -
trunk/LayoutTests/platform/mac/editing/inserting/insert-3800346-fix-expected.txt
r63291 r90275 12 12 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 13 13 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 14 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of DIV > DIV > BODY > HTML > #document to 3 of DIV > DIV > BODY > HTML > #document toDOMRange:range from 3 of DIV > DIV > BODY > HTML > #document to 3 of DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 14 15 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 15 16 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/inserting/insert-at-end-01-expected.txt
r63291 r90275 1 1 EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 6 of DIV > BODY > HTML > #document 2 2 EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification 3 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 3 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -
trunk/LayoutTests/platform/mac/editing/inserting/insert-at-end-02-expected.txt
r63291 r90275 1 1 EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 7 of DIV > BODY > HTML > #document 2 2 EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification 3 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 3 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -
trunk/LayoutTests/platform/mac/editing/inserting/insert-div-010-expected.txt
r63291 r90275 7 7 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification 8 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 9 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 9 10 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 10 11 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/inserting/insert-div-013-expected.txt
r63291 r90275 6 6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 7 7 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 8 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of #text > BODY > HTML > #document to 0 of #text > BODY > HTML > #document toDOMRange:range from 0 of #text > BODY > HTML > #document to 0 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 8 9 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 9 10 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/inserting/insert-div-015-expected.txt
r63291 r90275 10 10 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 11 11 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 12 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 12 13 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 13 14 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/inserting/insert-div-019-expected.txt
r63291 r90275 6 6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 7 7 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 8 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of BODY > HTML > #document to 5 of BODY > HTML > #document toDOMRange:range from 5 of BODY > HTML > #document to 5 of BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 8 9 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 9 10 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/inserting/insert-paragraph-03-expected.txt
r63291 r90275 4 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 5 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of DIV > BODY > HTML > #document to 3 of DIV > BODY > HTML > #document toDOMRange:range from 3 of DIV > BODY > HTML > #document to 3 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 6 7 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 7 8 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/pasteboard/3976872-expected.txt
r63291 r90275 8 8 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification 9 9 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 10 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 10 11 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 11 12 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt
r80121 r90275 5 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 6 EDITING DELEGATE: shouldDeleteDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 23 of #text > DIV > DIV > BODY > HTML > #document 7 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 8 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 8 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 7 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 8 9 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt
r80121 r90275 5 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 6 EDITING DELEGATE: shouldDeleteDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 14 of #text > DIV > DIV > BODY > HTML > #document 7 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 8 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 8 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 7 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 8 9 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/pasteboard/paste-text-014-expected.txt
r63291 r90275 12 12 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 13 13 EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted 14 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 14 15 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 15 16 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/selection/4932260-1-expected.txt
r63291 r90275 1 1 EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 3 of DIV > BODY > HTML > #document 2 2 EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification 3 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 3 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -
trunk/LayoutTests/platform/mac/editing/selection/expanding-selections-expected.txt
r81095 r90275 3 3 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of #text > SPAN > DIV > BODY > HTML > #document to 1 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 4 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 5 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > SPAN > DIV > BODY > HTML > #document to 1 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > SPAN > DIV > BODY > HTML > #document to 1 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 5 6 layer at (0,0) size 800x600 6 7 RenderView at (0,0) size 800x600 -
trunk/LayoutTests/platform/mac/editing/selection/expanding-selections2-expected.txt
r81095 r90275 3 3 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of #text > SPAN > DIV > BODY > HTML > #document to 1 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 4 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 5 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > SPAN > DIV > BODY > HTML > #document to 1 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > SPAN > DIV > BODY > HTML > #document to 1 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 5 6 layer at (0,0) size 800x600 6 7 RenderView at (0,0) size 800x600 -
trunk/LayoutTests/platform/mac/editing/selection/fake-drag-expected.txt
r81608 r90275 5 5 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 6 6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 7 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 7 8 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 8 9 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -
trunk/LayoutTests/platform/mac/editing/selection/move-by-word-001-expected.txt
r63291 r90275 1 1 EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 3 of DIV > BODY > HTML > #document 2 2 EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification 3 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 3 7 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -
trunk/LayoutTests/platform/mac/editing/selection/triple-click-in-pre-expected.txt
r81095 r90275 5 5 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 30 of #text > PRE > DIV > DIV > BODY > HTML > #document to 30 of #text > PRE > DIV > DIV > BODY > HTML > #document toDOMRange:range from 16 of #text > PRE > DIV > DIV > BODY > HTML > #document to 30 of #text > PRE > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 6 6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 7 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 16 of #text > PRE > DIV > DIV > BODY > HTML > #document to 30 of #text > PRE > DIV > DIV > BODY > HTML > #document toDOMRange:range from 16 of #text > PRE > DIV > DIV > BODY > HTML > #document to 30 of #text > PRE > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 7 8 layer at (0,0) size 800x600 8 9 RenderView at (0,0) size 800x600 -
trunk/LayoutTests/platform/mac/editing/style/create-block-for-style-008-expected.txt
r78910 r90275 3 3 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 4 4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 5 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 5 6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 7 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/undo/4063751-expected.txt
r80121 r90275 84 84 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 85 85 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 86 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of #text > DIV > DIV > BODY > HTML > #document to 2 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 2 of #text > DIV > DIV > BODY > HTML > #document to 2 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 86 87 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 87 88 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification … … 106 107 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 107 108 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 109 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of #text > DIV > DIV > BODY > HTML > #document to 2 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 2 of #text > DIV > DIV > BODY > HTML > #document to 2 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 108 110 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 109 111 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt
r80121 r90275 5 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 6 EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > SPAN > DIV > BODY > HTML > #document to 6 of #text > SPAN > DIV > BODY > HTML > #document 7 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > SPAN > DIV > BODY > HTML > #document to 5 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > SPAN > DIV > BODY > HTML > #document to 5 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 7 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 8 9 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/LayoutTests/platform/mac/editing/undo/undo-forward-delete-expected.txt
r80121 r90275 5 5 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 6 6 EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > SPAN > DIV > BODY > HTML > #document to 6 of #text > SPAN > DIV > BODY > HTML > #document 7 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > SPAN > DIV > BODY > HTML > #document to 5 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > SPAN > DIV > BODY > HTML > #document to 5 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 7 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 8 9 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -
trunk/Source/WebCore/ChangeLog
r90271 r90275 1 2011-07-01 Ryosuke Niwa <rniwa@webkit.org> 2 3 Reviewed by Ojan Vafai. 4 5 Move m_isDirectional from FrameSelection to VisibleSelection 6 https://bugs.webkit.org/show_bug.cgi?id=63473 7 8 Move m_isDirectional from FrameSelection to VisibleSelection. 9 10 Also fixed a bug that WebKit does not preserve non-directional selection after undo. 11 12 Test: editing/selection/directionality-after-undo-replace.html 13 14 * WebCore.exp.in: Updated the signature of setSelection. 15 * editing/FrameSelection.cpp: 16 (WebCore::FrameSelection::FrameSelection): Removed the call to setIsDirectional. 17 (WebCore::shouldAlwaysUseDirectionalSelection): Added. 18 (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy. 19 Calls setIsDirectional(true) when the platform doesn't support non-directional selection. 20 Passes align and granularity to setSelection of the base end point as expected. 21 No longer updates granularity when updating the selection of a different frame. 22 (WebCore::FrameSelection::willBeModified): Calls VisibleSelection::isDirectional(). 23 (WebCore::FrameSelection::modify): No longer calls trialFrameSelection.setIsDirectional 24 because the directionality is passed from m_selection automatically. 25 Also calls shouldAlwaysUseDirectionalSelection. 26 * editing/FrameSelection.h: Remove m_isDirectional. Make all boolean bit fields. 27 (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy. 28 * editing/VisibleSelection.cpp: 29 (WebCore::VisibleSelection::VisibleSelection): Initializes m_isDirectional to true. 30 This should be changed to false to fix the bug 60529. 31 * editing/VisibleSelection.h: 32 (WebCore::VisibleSelection::isDirectional): Added. 33 (WebCore::VisibleSelection::setIsDirectional): Added. 34 * page/EventHandler.cpp: 35 (WebCore::setNonDirectionalSelectionIfNeeded): Creates a non-directional selection instead of 36 calling setSelection with MakeNonDirectionalSelection. 37 (WebCore::EventHandler::handleMousePressEventSingleClick): Remove the call to setIsDirectional 38 because it already calls setNonDirectionalSelectionIfNeeded. 39 1 40 2011-07-01 Tony Chang <tony@chromium.org> 2 41 -
trunk/Source/WebCore/WebCore.exp.in
r90259 r90275 350 350 __ZN7WebCore14FileIconLoader14notifyFinishedEN3WTF10PassRefPtrINS_4IconEEE 351 351 __ZN7WebCore14FrameSelection10setFocusedEb 352 __ZN7WebCore14FrameSelection12setSelectionERKNS_16VisibleSelectionEjNS0_19CursorAlignOnScrollENS_15TextGranularityE NS_20DirectionalityPolicyE352 __ZN7WebCore14FrameSelection12setSelectionERKNS_16VisibleSelectionEjNS0_19CursorAlignOnScrollENS_15TextGranularityE 353 353 __ZN7WebCore14FrameSelection15revealSelectionERKNS_15ScrollAlignmentEb 354 354 __ZN7WebCore14FrameSelection16setSelectedRangeEPNS_5RangeENS_9EAffinityEb -
trunk/Source/WebCore/editing/FrameSelection.cpp
r90098 r90275 101 101 , m_focused(frame && frame->page() && frame->page()->focusController()->focusedFrame() == frame) 102 102 { 103 setIsDirectional(false);104 103 } 105 104 … … 152 151 } 153 152 154 void FrameSelection::setSelection(const VisibleSelection& s, SetSelectionOptions options, CursorAlignOnScroll align, TextGranularity granularity, DirectionalityPolicy directionalityPolicy) 155 { 156 m_granularity = granularity; 157 153 static inline bool shouldAlwaysUseDirectionalSelection(Frame* frame) 154 { 155 return !frame || frame->editor()->behavior().shouldConsiderSelectionAsDirectional(); 156 } 157 158 void FrameSelection::setSelection(const VisibleSelection& newSelection, SetSelectionOptions options, CursorAlignOnScroll align, TextGranularity granularity) 159 { 158 160 bool closeTyping = options & CloseTyping; 159 161 bool shouldClearTypingStyle = options & ClearTypingStyle; 160 162 EUserTriggered userTriggered = selectionOptionsToUserTriggered(options); 161 163 162 setIsDirectional(directionalityPolicy == MakeDirectionalSelection); 164 VisibleSelection s = newSelection; 165 if (shouldAlwaysUseDirectionalSelection(m_frame)) 166 s.setIsDirectional(true); 163 167 164 168 if (!m_frame) { … … 172 176 Document* document = s.base().anchorNode()->document(); 173 177 if (document && document->frame() && document->frame() != m_frame && document != m_frame->document()) { 174 document->frame()->selection()->setSelection(s, options );178 document->frame()->selection()->setSelection(s, options, align, granularity); 175 179 return; 176 180 } 177 181 } 182 183 m_granularity = granularity; 178 184 179 185 if (closeTyping) … … 358 364 } 359 365 360 void FrameSelection::setIsDirectional(bool isDirectional)361 {362 m_isDirectional = !m_frame || m_frame->editor()->behavior().shouldConsiderSelectionAsDirectional() || isDirectional;363 }364 365 366 TextDirection FrameSelection::directionOfEnclosingBlock() 366 367 { … … 378 379 bool baseIsStart = true; 379 380 380 if (m_ isDirectional) {381 if (m_selection.isDirectional()) { 381 382 // Make base and extent match start and end so we extend the user-visible selection. 382 383 // This only matters for cases where base and extend point to different positions than … … 783 784 FrameSelection trialFrameSelection; 784 785 trialFrameSelection.setSelection(m_selection); 785 trialFrameSelection.setIsDirectional(m_isDirectional);786 786 trialFrameSelection.modify(alter, direction, granularity, NotUserTriggered); 787 787 … … 864 864 setCaretRectNeedsUpdate(); 865 865 866 setIsDirectional(alter == AlterationExtend);866 m_selection.setIsDirectional(shouldAlwaysUseDirectionalSelection(m_frame) || alter == AlterationExtend); 867 867 868 868 return true; … … 887 887 FrameSelection trialFrameSelection; 888 888 trialFrameSelection.setSelection(m_selection); 889 trialFrameSelection.setIsDirectional(m_isDirectional);890 889 trialFrameSelection.modify(alter, verticalDistance, direction, NotUserTriggered); 891 890 … … 953 952 m_granularity = CharacterGranularity; 954 953 955 setIsDirectional(alter == AlterationExtend);954 m_selection.setIsDirectional(shouldAlwaysUseDirectionalSelection(m_frame) || alter == AlterationExtend); 956 955 957 956 return true; -
trunk/Source/WebCore/editing/FrameSelection.h
r89299 r90275 47 47 class VisiblePosition; 48 48 49 enum DirectionalityPolicy { MakeNonDirectionalSelection, MakeDirectionalSelection };50 49 enum EUserTriggered { NotUserTriggered = 0, UserTriggered = 1 }; 51 50 … … 136 135 137 136 const VisibleSelection& selection() const { return m_selection; } 138 void setSelection(const VisibleSelection&, SetSelectionOptions = CloseTyping | ClearTypingStyle, CursorAlignOnScroll = AlignCursorOnScrollIfNeeded, TextGranularity = CharacterGranularity , DirectionalityPolicy = MakeDirectionalSelection);139 void setSelection(const VisibleSelection& selection, TextGranularity granularity , DirectionalityPolicy directionality = MakeDirectionalSelection) { setSelection(selection, CloseTyping | ClearTypingStyle, AlignCursorOnScrollIfNeeded, granularity, directionality); }137 void setSelection(const VisibleSelection&, SetSelectionOptions = CloseTyping | ClearTypingStyle, CursorAlignOnScroll = AlignCursorOnScrollIfNeeded, TextGranularity = CharacterGranularity); 138 void setSelection(const VisibleSelection& selection, TextGranularity granularity) { setSelection(selection, CloseTyping | ClearTypingStyle, AlignCursorOnScrollIfNeeded, granularity); } 140 139 bool setSelectedRange(Range*, EAffinity, bool closeTyping); 141 140 void selectAll(); … … 180 179 void setCaretRectNeedsUpdate() { CaretBase::setCaretRectNeedsUpdate(); } 181 180 182 void setIsDirectional(bool);183 181 void willBeModified(EAlteration, SelectionDirection); 184 182 … … 287 285 IntRect m_absCaretBounds; // absolute bounding rect for the caret 288 286 IntRect m_absoluteCaretRepaintBounds; 289 bool m_absCaretBoundsDirty; 290 bool m_caretPaint; 291 292 bool m_isDirectional; 293 bool m_isCaretBlinkingSuspended; 294 bool m_focused; 287 bool m_absCaretBoundsDirty : 1; 288 bool m_caretPaint : 1; 289 bool m_isCaretBlinkingSuspended : 1; 290 bool m_focused : 1; 295 291 }; 296 292 -
trunk/Source/WebCore/editing/VisibleSelection.cpp
r87067 r90275 45 45 , m_selectionType(NoSelection) 46 46 , m_baseIsFirst(true) 47 , m_isDirectional(true) 47 48 { 48 49 } … … 52 53 , m_extent(pos) 53 54 , m_affinity(affinity) 55 , m_isDirectional(true) 54 56 { 55 57 validate(); … … 60 62 , m_extent(extent) 61 63 , m_affinity(affinity) 64 , m_isDirectional(true) 62 65 { 63 66 validate(); … … 68 71 , m_extent(pos.deepEquivalent()) 69 72 , m_affinity(pos.affinity()) 73 , m_isDirectional(true) 70 74 { 71 75 validate(); … … 76 80 , m_extent(extent.deepEquivalent()) 77 81 , m_affinity(base.affinity()) 82 , m_isDirectional(true) 78 83 { 79 84 validate(); … … 84 89 , m_extent(range->endPosition()) 85 90 , m_affinity(affinity) 91 , m_isDirectional(true) 86 92 { 87 93 validate(); -
trunk/Source/WebCore/editing/VisibleSelection.h
r87067 r90275 79 79 80 80 bool isBaseFirst() const { return m_baseIsFirst; } 81 bool isDirectional() const { return m_isDirectional; } 82 void setIsDirectional(bool isDirectional) { m_isDirectional = isDirectional; } 81 83 82 84 bool isAll(EditingBoundaryCrossingRule) const; … … 123 125 // undoing the command. We need to be able to create a selection that, while currently 124 126 // invalid, will be valid once the changes are undone. 125 127 126 128 Position m_base; // Where the first click happened 127 129 Position m_extent; // Where the end click happened … … 132 134 133 135 // these are cached, can be recalculated by validate() 134 SelectionType m_selectionType; // None, Caret, Range 135 bool m_baseIsFirst; // true if base is before the extent 136 SelectionType m_selectionType; // None, Caret, Range 137 bool m_baseIsFirst : 1; // True if base is before the extent 138 bool m_isDirectional : 1; // Non-directional ignores m_baseIsFirst and selection always extends on shift + arrow key. 136 139 }; 137 140 138 141 inline bool operator==(const VisibleSelection& a, const VisibleSelection& b) 139 142 { 140 return a.start() == b.start() && a.end() == b.end() && a.affinity() == b.affinity() && a.isBaseFirst() == b.isBaseFirst(); 143 return a.start() == b.start() && a.end() == b.end() && a.affinity() == b.affinity() && a.isBaseFirst() == b.isBaseFirst() 144 && a.isDirectional() == b.isDirectional(); 141 145 } 142 146 -
trunk/Source/WebCore/page/EventHandler.cpp
r89293 r90275 278 278 { 279 279 ASSERT(selection); 280 if (selection->selection() != newSelection && selection->shouldChangeSelection(newSelection)) 281 selection->setSelection(newSelection, granularity, MakeNonDirectionalSelection); 280 if (selection->selection() == newSelection || !selection->shouldChangeSelection(newSelection)) 281 return; 282 283 VisibleSelection newNonDirectionalSelection = newSelection; 284 newNonDirectionalSelection.setIsDirectional(false); 285 286 selection->setSelection(newNonDirectionalSelection, granularity); 282 287 } 283 288 … … 410 415 visiblePos = VisiblePosition(firstPositionInOrBeforeNode(innerNode), DOWNSTREAM); 411 416 Position pos = visiblePos.deepEquivalent(); 412 417 413 418 VisibleSelection newSelection = m_frame->selection()->selection(); 414 419 TextGranularity granularity = CharacterGranularity; 415 420 416 421 if (extendSelection && newSelection.isCaretOrRange()) { 417 m_frame->selection()->setIsDirectional(false);418 419 422 ASSERT(m_frame->settings()); 420 423 if (m_frame->settings()->editingBehaviorType() == EditingMacBehavior) { -
trunk/Source/WebKit/chromium/ChangeLog
r90249 r90275 1 2011-07-01 Ryosuke Niwa <rniwa@webkit.org> 2 3 Reviewed by Ojan Vafai. 4 5 Move m_isDirectional from FrameSelection to VisibleSelection 6 https://bugs.webkit.org/show_bug.cgi?id=63473 7 8 Don't pass MakeNonDirectionalSelection to setSelection since no other port does this. 9 10 * src/WebFrameImpl.cpp: 11 (WebKit::WebFrameImpl::selectRange): 12 1 13 2011-07-01 Andrew Scherkus <scherkus@chromium.org> 2 14 -
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
r90025 r90275 1287 1287 1288 1288 if (frame()->selection()->shouldChangeSelection(selection)) 1289 frame()->selection()->setSelection(selection, CharacterGranularity, 1290 MakeNonDirectionalSelection); 1289 frame()->selection()->setSelection(selection, CharacterGranularity); 1291 1290 } 1292 1291
Note: See TracChangeset
for help on using the changeset viewer.