Changeset 90340 in webkit

Timestamp:

Jul 3, 2011 8:58:38 AM (13 years ago)

Author:

vsevik@chromium.org

Message:

2011-07-03 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
​https://bugs.webkit.org/show_bug.cgi?id=63712

• http/tests/inspector/network-preflight-options-expected.txt:
• http/tests/inspector/network-preflight-options.html:

2011-07-03 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
​https://bugs.webkit.org/show_bug.cgi?id=63712

Added InspectorInstrumentation calls to preflight OPTIONS requests callbacks in DocumentThreadableLoader.

• loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::didFinishLoading): (WebCore::DocumentThreadableLoader::didFail): (WebCore::DocumentThreadableLoader::loadRequest):
• loader/DocumentThreadableLoader.h:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/inspector/network-preflight-options-expected.txt (modified) (2 diffs)
• LayoutTests/http/tests/inspector/network-preflight-options.html (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/loader/DocumentThreadableLoader.cpp (modified) (7 diffs)
• Source/WebCore/loader/DocumentThreadableLoader.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-03  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
+        https://bugs.webkit.org/show_bug.cgi?id=63712
+
+        * http/tests/inspector/network-preflight-options-expected.txt:
+        * http/tests/inspector/network-preflight-options.html:
+
 2011-07-03  Robert Hogan  <robert@webkit.org>
 

trunk/LayoutTests/http/tests/inspector/network-preflight-options-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
+CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
 CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
 CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
@@ -7 +9 @@
 OPTIONS http://localhost:8000/inspector/resources/cors-target.php
 POST http://localhost:8000/inspector/resources/cors-target.php
+POST http://localhost:8000/inspector/resources/cors-target.php?deny=yes
+OPTIONS http://localhost:8000/inspector/resources/cors-target.php?deny=yes
+OPTIONS http://localhost:8000/inspector/resources/cors-target.php?async=yes
+POST http://localhost:8000/inspector/resources/cors-target.php?async=yes
 

trunk/LayoutTests/http/tests/inspector/network-preflight-options.html

@@ -4 +4 @@
 <script type="text/javascript">
 
-function sendXHR(url, forcePreflight)
+function sendXHR(url, forcePreflight, async)
 {
     var xhr = new XMLHttpRequest();
-    xhr.open("POST", url, false);
+    xhr.open("POST", url, async);
     xhr.setRequestHeader("Content-Type", forcePreflight ? "application/xml" : "text/plain");
     try {
@@ -18 +18 @@
 {
     var targetURL = "http://localhost:8000/inspector/resources/cors-target.php";
+
     // Failed POSTs with no preflight check should result in a POST request being logged
-    sendXHR(targetURL + "?deny=yes", false);
+    sendXHR(targetURL + "?deny=yes", false, false);
     // Failed POSTs with preflight check should result in an OPTIONS request being logged
-    sendXHR(targetURL + "?deny=yes", true);
+    sendXHR(targetURL + "?deny=yes", true, false);
     // Successful POSTs with preflight check should result in an OPTIONS request followed by POST request being logged
-    // Generate request name based on timestamp to defeat caching (this is only relevant for repeated invocations of the test in signle instance of DRT)
-    sendXHR(targetURL + "?date=" + Date.now(), true);
+    // Generate request name based on timestamp to defeat OPTIONS request caching (this is only relevant for repeated invocations of the test in signle instance of DRT)
+    sendXHR(targetURL + "?date=" + Date.now(), true, false);
+
+    // And now send the same requests asynchronously
+    // Add redundant async parameter to ensure this request differs from the one above.
+    sendXHR(targetURL + "?deny=yes", false, true);
+    sendXHR(targetURL + "?deny=yes", true, true);
+    sendXHR(targetURL + "?async=yes&date=" + Date.now(), true, true);
 }
 
 var test = function()
 {
+    var postRequestsCount = 0;
     function onResource(event)
     {
         var resource = event.data;
         InspectorTest.addResult(resource.requestMethod + " " +  resource.url.replace(/[&?]date=\d+/, ""));
-        if (resource.requestMethod === "POST" && !/\?deny=yes/.test(resource.url))
+        if (resource.requestMethod === "POST" && ++postRequestsCount == 4)
             InspectorTest.completeTest();
     }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-03  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
+        https://bugs.webkit.org/show_bug.cgi?id=63712
+
+        Added InspectorInstrumentation calls to preflight OPTIONS requests callbacks in DocumentThreadableLoader.
+
+        * loader/DocumentThreadableLoader.cpp:
+        (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
+        (WebCore::DocumentThreadableLoader::didReceiveResponse):
+        (WebCore::DocumentThreadableLoader::didReceiveData):
+        (WebCore::DocumentThreadableLoader::didFinishLoading):
+        (WebCore::DocumentThreadableLoader::didFail):
+        (WebCore::DocumentThreadableLoader::loadRequest):
+        * loader/DocumentThreadableLoader.h:
+
 2011-06-23  Robert Hogan  <robert@webkit.org>
 

trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp

@@ -47 +47 @@
 #include <wtf/UnusedParam.h>
 
+#if ENABLE(INSPECTOR)
+#include "InspectorInstrumentation.h"
+#include "ProgressTracker.h"
+#endif
+
 namespace WebCore {
 
@@ -70 +75 @@
     , m_sameOriginRequest(securityOrigin()->canRequest(request.url()))
     , m_async(blockingBehavior == LoadAsynchronously)
+#if ENABLE(INSPECTOR)
+    , m_preflightRequestIdentifier(0)
+#endif
 {
     ASSERT(document);
@@ -178 +186 @@
 {
     ASSERT(m_client);
+
+#if ENABLE(INSPECTOR)
+    if (m_preflightRequestIdentifier) {
+        DocumentLoader* loader = m_document->frame()->loader()->documentLoader();
+        InspectorInstrumentationCookie cookie = InspectorInstrumentation::willReceiveResourceResponse(m_document->frame(), m_preflightRequestIdentifier, response);
+        InspectorInstrumentation::didReceiveResourceResponse(cookie, m_preflightRequestIdentifier, loader, response);
+    }
+#endif
 
     String accessControlErrorDescription;
@@ -212 +228 @@
     ASSERT_UNUSED(loader, loader == m_loader);
 
+#if ENABLE(INSPECTOR)
+    if (m_preflightRequestIdentifier)
+        InspectorInstrumentation::didReceiveContentLength(m_document->frame(), m_preflightRequestIdentifier, 0, dataLength);
+#endif
+
     // Preflight data should be invisible to clients.
     if (m_actualRequest)
@@ -240 +261 @@
 void DocumentThreadableLoader::didFinishLoading(unsigned long identifier, double finishTime)
 {
+#if ENABLE(INSPECTOR)
+    if (m_preflightRequestIdentifier)
+        InspectorInstrumentation::didFinishLoading(m_document->frame(), m_document->frame()->loader()->documentLoader(), m_preflightRequestIdentifier, finishTime);
+#endif
+
     if (m_actualRequest) {
         ASSERT(!m_sameOriginRequest);
@@ -253 +279 @@
     // m_loader may be null if we arrive here via SubresourceLoader::create in the ctor
     ASSERT_UNUSED(loader, loader == m_loader || !m_loader);
+
+#if ENABLE(INSPECTOR)
+    if (m_preflightRequestIdentifier)
+        InspectorInstrumentation::didFailLoading(m_document->frame(), m_document->frame()->loader()->documentLoader(), m_preflightRequestIdentifier, error);
+#endif
 
     m_client->didFail(error);
@@ -324 +355 @@
         bool shouldBufferData = m_options.shouldBufferData || m_actualRequest;
 
+#if ENABLE(INSPECTOR)
+        if (m_actualRequest) {
+            ResourceRequest newRequest(request);
+            // Because willSendRequest only gets called during redirects, we initialize the identifier and the first willSendRequest here.
+            m_preflightRequestIdentifier = m_document->frame()->page()->progress()->createUniqueIdentifier();
+            ResourceResponse redirectResponse = ResourceResponse();
+            InspectorInstrumentation::willSendRequest(m_document->frame(), m_preflightRequestIdentifier, m_document->frame()->loader()->documentLoader(), newRequest, redirectResponse);
+        }
+#endif
+
         // Clear the loader so that any callbacks from SubresourceLoader::create will not have the old loader.
         m_loader = 0;

trunk/Source/WebCore/loader/DocumentThreadableLoader.h

@@ -106 +106 @@
         bool m_async;
         OwnPtr<ResourceRequest> m_actualRequest;  // non-null during Access Control preflight checks
+
+#if ENABLE(INSPECTOR)
+        unsigned long m_preflightRequestIdentifier;
+#endif
     };