Changeset 90355 in webkit

Timestamp:

Jul 4, 2011 2:20:15 AM (13 years ago)

Author:

caseq@chromium.org

Message:

2011-07-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] audit formatter names should begin with create
​https://bugs.webkit.org/show_bug.cgi?id=63802

• inspector/extensions/extensions-audits-api-expected.txt:
• inspector/extensions/extensions-audits.html:

2011-07-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] audit formatter names should begin with create
​https://bugs.webkit.org/show_bug.cgi?id=63802

• inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.AuditResultImpl):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/extensions/extensions-audits-api-expected.txt (modified) (1 diff)
• LayoutTests/inspector/extensions/extensions-audits.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/ExtensionAPI.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-04  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: [Extensions API] audit formatter names should begin with create
+        https://bugs.webkit.org/show_bug.cgi?id=63802
+
+        * inspector/extensions/extensions-audits-api-expected.txt:
+        * inspector/extensions/extensions-audits.html:
+
 2011-07-04  Yuta Kitamura  <yutak@chromium.org>
 

trunk/LayoutTests/inspector/extensions/extensions-audits-api-expected.txt

@@ -14 +14 @@
 category.onAuditStarted fired, results dump follows:
 {
-    url : <function>
-    snippet : <function>
-    text : <function>
+    createURL : <function>
+    createSnippet : <function>
+    createText : <function>
     addResult : <function>
     createResult : <function>

trunk/LayoutTests/inspector/extensions/extensions-audits.html

@@ -17 +17 @@
 
         var node = results.createResult("Subtree");
-        node.addChild("Some url: ", results.url("http://www.webkit.org", "WebKit"), " more text ", results.url("http://www.google.com"));
+        node.addChild("Some url: ", results.createURL("http://www.webkit.org", "WebKit"), " more text ", results.createURL("http://www.google.com"));
         var nestedNode = node.addChild("... and a snippet");
         nestedNode.expanded = true;
-        nestedNode.addChild(results.snippet("function rand()\n{\n    return 4;\n}"));
+        nestedNode.addChild(results.createSnippet("function rand()\n{\n    return 4;\n}"));
 
         results.addResult("Rule with details subtree (1)", "This rule has a lot of details", results.Severity.Warning, node);

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-04  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: [Extensions API] audit formatter names should begin with create
+        https://bugs.webkit.org/show_bug.cgi?id=63802
+
+        * inspector/front-end/ExtensionAPI.js:
+        (WebInspector.injectedExtensionAPI.AuditResultImpl):
+
 2011-07-03  Dominic Cooney  <dominicc@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js

@@ -288 +288 @@
     this._id = id;
 
-    var formatterTypes = [
-        "url",
-        "snippet",
-        "text"
-    ];
-    for (var i = 0; i < formatterTypes.length; ++i)
-        this[formatterTypes[i]] = bind(this._nodeFactory, null, formatterTypes[i]);
+    this.createURL = bind(this._nodeFactory, null, "url");
+    this.createSnippet = bind(this._nodeFactory, null, "snippet");
+    this.createText = bind(this._nodeFactory, null, "text");
 }