Changeset 90360 in webkit

Timestamp:

Jul 4, 2011 4:55:59 AM (13 years ago)

Author:

apavlov@chromium.org

Message:

2011-07-04 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Adding new CSS rules should be more discoverable in the UI
​https://bugs.webkit.org/show_bug.cgi?id=63803

• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._createNewRule):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/StylesSidebarPane.js (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-04  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: Adding new CSS rules should be more discoverable in the UI
+        https://bugs.webkit.org/show_bug.cgi?id=63803
+
+        * inspector/front-end/StylesSidebarPane.js:
+        (WebInspector.StylesSidebarPane.prototype._createNewRule):
+
 2011-07-04  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
 

trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js

@@ -59 +59 @@
     this.settingsSelectElement.appendChild(option);
 
-    this.settingsSelectElement.appendChild(document.createElement("hr"));
-
-    option = document.createElement("option");
-    option.action = this._createNewRule.bind(this);
-    option.label = WebInspector.UIString("New Style Rule");
-    this.settingsSelectElement.appendChild(option);
-
     this.settingsSelectElement.addEventListener("click", function(event) { event.stopPropagation() }, false);
     this.settingsSelectElement.addEventListener("change", this._changeSetting.bind(this), false);
@@ -79 +72 @@
 
     this.titleElement.appendChild(this.settingsSelectElement);
+
+    var addButton = document.createElement("button");
+    addButton.className = "pane-title-button add";
+    addButton.title = WebInspector.UIString("New Style Rule");
+    addButton.addEventListener("click", this._createNewRule.bind(this), false);
+    this.titleElement.appendChild(addButton);
+
     this._computedStylePane = computedStylePane;
     this.element.addEventListener("contextmenu", this._contextMenuEventFired.bind(this), true);
@@ -579 +579 @@
     _createNewRule: function(event)
     {
+        event.stopPropagation();
+        if (WebInspector.isEditingAnyField())
+            return;
+
         this.expanded = true;
         this.addBlankSection().startEditingSelector();