Changeset 90376 in webkit

Timestamp:

Jul 4, 2011 1:28:13 PM (13 years ago)

Author:

vsevik@chromium.org

Message:

2011-07-04 Vsevolod Vlasov <​vsevik@chromium.org>

ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
​https://bugs.webkit.org/show_bug.cgi?id=63873

Reviewed by Alexey Proskuryakov.

• loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/ResourceLoadNotifier.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
+        https://bugs.webkit.org/show_bug.cgi?id=63873
+
+        Reviewed by Alexey Proskuryakov.
+
+        * loader/ResourceLoadNotifier.cpp:
+        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
+
 2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/loader/ResourceLoadNotifier.cpp

@@ -108 +108 @@
 void ResourceLoadNotifier::dispatchWillSendRequest(DocumentLoader* loader, unsigned long identifier, ResourceRequest& request, const ResourceResponse& redirectResponse)
 {
-    StringImpl* oldRequestURL = request.url().string().impl();
+    String oldRequestURL = request.url().string();
     m_frame->loader()->documentLoader()->didTellClientAboutLoad(request.url());
 
@@ -114 +114 @@
 
     // If the URL changed, then we want to put that new URL in the "did tell client" set too.
-    if (!request.isNull() && oldRequestURL != request.url().string().impl())
+    if (!request.isNull() && oldRequestURL != request.url().string())
         m_frame->loader()->documentLoader()->didTellClientAboutLoad(request.url());