Changeset 90399 in webkit

Timestamp:

Jul 5, 2011 9:07:35 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-07-05 Tamas Czene <​Czene.Tamas@stud.u-szeged.hu>

Reviewed by Simon Fraser.

Remove virtual functions from StyleImage.
​https://bugs.webkit.org/show_bug.cgi?id=63909

We can remove the virtual "isChachedImage, isPendingImage, isGeneratedImage" functions to speed up the StyleImage.
Some profile data shows this part is significant, especially in small CSS-based sites.
Removing the virtual functions - removing the calls - makes a small performance progression on this part.

• rendering/style/StyleCachedImage.h: (WebCore::StyleCachedImage::StyleCachedImage):
• rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::StyleGeneratedImage):
• rendering/style/StyleImage.h: (WebCore::StyleImage::isCachedImage): (WebCore::StyleImage::isPendingImage): (WebCore::StyleImage::isGeneratedImage): (WebCore::StyleImage::StyleImage):
• rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::StylePendingImage):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/style/StyleCachedImage.h (modified) (2 diffs)
• rendering/style/StyleGeneratedImage.h (modified) (2 diffs)
• rendering/style/StyleImage.h (modified) (2 diffs)
• rendering/style/StylePendingImage.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-05  Tamas Czene  <Czene.Tamas@stud.u-szeged.hu>
+
+        Reviewed by Simon Fraser.
+
+        Remove virtual functions from StyleImage.
+        https://bugs.webkit.org/show_bug.cgi?id=63909
+
+        We can remove the virtual "isChachedImage, isPendingImage, isGeneratedImage" functions to speed up the StyleImage.
+        Some profile data shows this part is significant, especially in small CSS-based sites.
+        Removing the virtual functions - removing the calls - makes a small performance progression on this part.
+
+        * rendering/style/StyleCachedImage.h:
+        (WebCore::StyleCachedImage::StyleCachedImage):
+        * rendering/style/StyleGeneratedImage.h:
+        (WebCore::StyleGeneratedImage::StyleGeneratedImage):
+        * rendering/style/StyleImage.h:
+        (WebCore::StyleImage::isCachedImage):
+        (WebCore::StyleImage::isPendingImage):
+        (WebCore::StyleImage::isGeneratedImage):
+        (WebCore::StyleImage::StyleImage):
+        * rendering/style/StylePendingImage.h:
+        (WebCore::StylePendingImage::StylePendingImage):
+
 2011-07-05  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/rendering/style/StyleCachedImage.h

@@ -37 +37 @@
     virtual WrappedImagePtr data() const { return m_image.get(); }
 
-    virtual bool isCachedImage() const { return true; }
-    
     virtual PassRefPtr<CSSValue> cssValue() const;
     
@@ -59 +57 @@
         : m_image(image)
     {
+         m_isCachedImage = true;
     }
     

trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h

@@ -41 +41 @@
     virtual WrappedImagePtr data() const { return m_generator; }
 
-    virtual bool isGeneratedImage() const { return true; }
-    
     virtual PassRefPtr<CSSValue> cssValue() const;
 
@@ -59 +57 @@
         , m_fixedSize(fixedSize)
     {
+         m_isGeneratedImage = true;
     }
     

trunk/Source/WebCore/rendering/style/StyleImage.h

@@ -63 +63 @@
     virtual WrappedImagePtr data() const = 0;
 
-    virtual bool isCachedImage() const { return false; }
-    virtual bool isPendingImage() const { return false; }
-    virtual bool isGeneratedImage() const { return false; }
+    ALWAYS_INLINE bool isCachedImage() const { return m_isCachedImage; }
+    ALWAYS_INLINE bool isPendingImage() const { return m_isPendingImage; }
+    ALWAYS_INLINE bool isGeneratedImage() const { return m_isGeneratedImage; }
     
     static  bool imagesEquivalent(StyleImage* image1, StyleImage* image2)
@@ -78 +78 @@
 
 protected:
-    StyleImage() { }
+    StyleImage()
+        : m_isCachedImage(false)
+        , m_isPendingImage(false)
+        , m_isGeneratedImage(false)
+    {
+    }
+    bool m_isCachedImage:1;
+    bool m_isPendingImage:1;
+    bool m_isGeneratedImage:1;
 };
 

trunk/Source/WebCore/rendering/style/StylePendingImage.h

@@ -42 +42 @@
     virtual WrappedImagePtr data() const { return m_value; }
 
-    virtual bool isPendingImage() const { return true; }
-    
     virtual PassRefPtr<CSSValue> cssValue() const { return m_value; }
     CSSImageValue* cssImageValue() const { return m_value; }
@@ -64 +62 @@
         : m_value(value)
     {
+        m_isPendingImage = true;
     }