Changeset 90407 in webkit
- Timestamp:
- Jul 5, 2011 3:13:41 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r90406 r90407 1 2011-07-05 Hans Wennborg <hans@chromium.org> 2 3 [V8][Chromium] Remove use of OwnHandle from V8LocalContext 4 https://bugs.webkit.org/show_bug.cgi?id=63925 5 6 Reviewed by Adam Barth. 7 8 Replace the OwnHandle<> member in V8LocalContext with 9 v8::Persistent<v8::Context>. 10 The code that used OwnHandle<> would not correctly Dispose 11 of the Context, which would cause the memory to fill up when creating 12 and destructing many V8LocalContext objects, such as in the case 13 of IndexedDB. 14 15 * bindings/v8/V8Utilities.cpp: 16 (WebCore::V8LocalContext::V8LocalContext): 17 (WebCore::V8LocalContext::~V8LocalContext): 18 * bindings/v8/V8Utilities.h: 19 1 20 2011-07-05 Igor Oliveira <igor.oliveira@openbossa.org> 2 21 -
trunk/Source/WebCore/bindings/v8/V8Utilities.cpp
r88731 r90407 50 50 51 51 V8LocalContext::V8LocalContext() 52 : m_context(v8::Context::New()) 52 53 { 53 54 V8BindingPerIsolateData::ensureInitialized(v8::Isolate::GetCurrent()); 54 m_context.set(v8::Context::New()); 55 m_context.get()->Enter(); 55 m_context->Enter(); 56 56 } 57 57 58 58 59 V8LocalContext::~V8LocalContext() 59 V8LocalContext::~V8LocalContext() 60 60 { 61 m_context.get()->Exit(); 61 m_context->Exit(); 62 m_context.Dispose(); 62 63 } 63 64 -
trunk/Source/WebCore/bindings/v8/V8Utilities.h
r88731 r90407 72 72 private: 73 73 v8::HandleScope m_handleScope; 74 OwnHandle<v8::Context> m_context;74 v8::Persistent<v8::Context> m_context; 75 75 }; 76 76
Note: See TracChangeset
for help on using the changeset viewer.