Changeset 90428 in webkit

Timestamp:

Jul 5, 2011 7:32:14 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-07-05 Adam Barth <​abarth@webkit.org>

garden-o-matic should understand which tests have unexpected failures
​https://bugs.webkit.org/show_bug.cgi?id=63965

Reviewed by Eric Seidel.

Currently, this code just logs the list of unexpected failures to the
console. A future patch will do something useful with this
information. A testing harness will also come in the next patch.

• Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Added.
• Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
• Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
• Scripts/webkitpy/tool/servers/gardeningserver.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/servers/data/gardeningserver/base.js (added)
• Scripts/webkitpy/tool/servers/data/gardeningserver/index.html (modified) (1 diff)
• Scripts/webkitpy/tool/servers/data/gardeningserver/results.js (modified) (2 diffs)
• Scripts/webkitpy/tool/servers/gardeningserver.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-05  Adam Barth  <abarth@webkit.org>
+
+        garden-o-matic should understand which tests have unexpected failures
+        https://bugs.webkit.org/show_bug.cgi?id=63965
+
+        Reviewed by Eric Seidel.
+
+        Currently, this code just logs the list of unexpected failures to the
+        console.  A future patch will do something useful with this
+        information.  A testing harness will also come in the next patch.
+
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Added.
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
+        * Scripts/webkitpy/tool/servers/gardeningserver.py:
+
 2011-07-05  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html

@@ -35 +35 @@
 </ul>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
+<script src="base.js"></script>
 <script src="main.js"></script>
 <script src="results.js"></script>

trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js

@@ -4 +4 @@
   var RESULTS_NAME = 'full_results.json';
   var MASTER_NAME = 'ChromiumWebkit';
+  var FAILING_RESULTS = ['TIMEOUT', 'TEXT', 'CRASH', 'IMAGE','IMAGE+TEXT'];
+
+  function isFailure(result) {
+    return FAILING_RESULTS.indexOf(result) != -1;
+  }
+
+  function anyIsFailure(results_list) {
+    return $.grep(results_list, isFailure).length > 0;
+  }
+
+  function addImpliedExpectations(results_list) {
+    if (results_list.indexOf('FAIL') == -1)
+      return results_list;
+    return results_list.concat(FAILING_RESULTS);
+  }
+
+  function unexpectedResults(result_node) {
+    var actual_results = result_node.actual.split(' ');
+    var expected_results = addImpliedExpectations(result_node.expected.split(' '))
+
+    return $.grep(actual_results, function(result) {
+      return expected_results.indexOf(result) == -1;
+    });
+  }
+
+  function isUnexpectedFailure(result_node) {
+    return anyIsFailure(unexpectedResults(result_node));
+  }
+
+  function isResultNode(node) {
+    return !!node.actual;
+  }
+
+  function logUnexpectedFailures(results_json) {
+    unexpected_failures = base.filterTree(results_json.tests, isResultNode, isUnexpectedFailure);
+    console.log('== Unexpected Failures ==')
+    console.log(unexpected_failures);
+  }
 
   function resultsURL(builder_name, name) {
@@ -21 +59 @@
   }
 
-  fetchResults('Webkit Linux', function(data) {
-    console.log("== Results ==")
-    console.log(data);
-  });
+  fetchResults('Webkit Linux', logUnexpectedFailures);
 })();

trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py

@@ -38 +38 @@
     STATIC_FILE_NAMES = frozenset([
         "index.html",
+        "base.js",
         "main.js",
         "results.js",