Changeset 90430 in webkit

Timestamp:

Jul 5, 2011 8:15:24 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-07-05 Adam Barth <​abarth@webkit.org>

Add first unit tests for garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=63969

Reviewed by Eric Seidel.

I've also reformated base.js to match WebKit style, as discussed in the
previous bug.

• Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
• Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Added.
• Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Added.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/servers/data/gardeningserver/base.js (modified) (1 diff)
• Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js (added)
• Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html (added)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-05  Adam Barth  <abarth@webkit.org>
+
+        Add first unit tests for garden-o-matic
+        https://bugs.webkit.org/show_bug.cgi?id=63969
+
+        Reviewed by Eric Seidel.
+
+        I've also reformated base.js to match WebKit style, as discussed in the
+        previous bug.
+
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Added.
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Added.
+
 2011-07-05  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js

@@ -1 +1 @@
 var base = base || {};
 
-(function() {
-  base.joinPath = function(parent, child) {
+(function(){
+
+base.joinPath = function(parent, child)
+{
+    if (parent.length == 0)
+        return child;
     return parent + '/' + child;
-  }
+}
 
-  base.filterTree = function(tree, is_leaf, predicate) {
-    var filtered_tree = {};
+base.filterTree = function(tree, isLeaf, predicate)
+{
+    var filteredTree = {};
 
-    function walkSubtree(subtree, directory) {
-      for (var child_name in subtree) {
-        var child = subtree[child_name];
-        var child_path = base.joinPath(directory, child_name);
-        if (is_leaf(child)) {
-          if (predicate(child))
-            filtered_tree[child_path] = child;
-          continue;
+    function walkSubtree(subtree, directory)
+    {
+        for (var childName in subtree) {
+            var child = subtree[childName];
+            var childPath = base.joinPath(directory, childName);
+            if (isLeaf(child)) {
+                if (predicate(child))
+                    filteredTree[childPath] = child;
+                continue;
+            }
+            walkSubtree(child, childPath);
         }
-        walkSubtree(child, child_path);
-      }
     }
 
     walkSubtree(tree, '');
-    return filtered_tree;
-  }
+    return filteredTree;
+}
+
 })();