Changeset 90436 in webkit

Timestamp:

Jul 5, 2011 10:29:48 PM (13 years ago)

Author:

tkent@chromium.org

Message:

2011-06-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Alexey Proskuryakov.

[Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
​https://bugs.webkit.org/show_bug.cgi?id=63573

• fast/forms/input-appearance-range.html: Give a focus on a slider to check focus appearance.
• platform/chromium/test_expectations.txt:
• platform/mac/fast/forms/input-appearance-range-expected.png:

2011-06-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Alexey Proskuryakov.

[Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
​https://bugs.webkit.org/show_bug.cgi?id=63573

• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb): Need to pass the RenderObject of the owner <input> because updateFocusedState() checks the outline style of the specified renderer, and we'd like to make a slider thumb reflect the owner focus style.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/input-appearance-range.html (modified) (2 diffs)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (1 diff)
• LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.png (modified) (previous)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderThemeMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-29  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        [Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
+        https://bugs.webkit.org/show_bug.cgi?id=63573
+
+        * fast/forms/input-appearance-range.html:
+          Give a focus on a slider to check focus appearance.
+        * platform/chromium/test_expectations.txt:
+        * platform/mac/fast/forms/input-appearance-range-expected.png:
+
 2011-07-05  Eric Seidel  <eric@webkit.org>
 

trunk/LayoutTests/fast/forms/input-appearance-range.html

@@ -3 +3 @@
 <!--
   You'll see
-   - three horizontal sliders with various thumb positions.
-   - a vertical slider
-   - a slant slider
+   - three horizontal sliders with various thumb positions
+   - a vertical slider, and
+   - a slant slider.
+  The second slider has focus.
 -->
 
@@ -15 +16 @@
 
 <div><input type=range value=75 style="-webkit-transform: rotate(30deg)"></div>
+
+<script>
+document.getElementsByTagName('input')[1].focus();
+</script>
 </body>

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -3946 +3946 @@
 BUGCR87009 : fast/filesystem/async-operations.html = PASS CRASH
 
+// Test has been updated.  Need rebaseline.
+BUGWK63573 : fast/forms/input-appearance-range.html = IMAGE
+
 // Strange scrollbar.
 BUGWK63115 : fast/css/font-face-in-shadow-DOM.html = PASS IMAGE+TEXT

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-29  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        [Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
+        https://bugs.webkit.org/show_bug.cgi?id=63573
+
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::paintSliderThumb):
+        Need to pass the RenderObject of the owner <input> because
+        updateFocusedState() checks the outline style of the specified
+        renderer, and we'd like to make a slider thumb reflect the owner
+        focus style.
+
 2011-07-05  Hans Wennborg  <hans@chromium.org>
 

trunk/Source/WebCore/rendering/RenderThemeMac.mm

@@ -1319 +1319 @@
     updateActiveState(sliderThumbCell, o);
     updateEnabledState(sliderThumbCell, o);
-    updateFocusedState(sliderThumbCell, o);
+    updateFocusedState(sliderThumbCell, (o->node() && o->node()->focusDelegate()->renderer()) ? o->node()->focusDelegate()->renderer() : o);
 
     // Update the pressed state using the NSCell tracking methods, since that's how NSSliderCell keeps track of it.