Changeset 90496 in webkit


Ignore:
Timestamp:
Jul 6, 2011 2:10:43 PM (13 years ago)
Author:
Dimitri Glazkov
Message:

2011-07-06 Dimitri Glazkov <Dimitri Glazkov>

garden-o-matic should use a favicon to indicate current state.
​https://bugs.webkit.org/show_bug.cgi?id=64027

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
Location:
trunk/Tools
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r90495 r90496  
     12011-07-06  Dimitri Glazkov  <dglazkov@chromium.org>
     2
     3        garden-o-matic should use a favicon to indicate current state.
     4        https://bugs.webkit.org/show_bug.cgi?id=64027
     5
     6        Reviewed by Adam Barth.
     7
     8        * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
     9        * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
     10        * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
     11        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
     12        * Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
     13
    1142011-07-06  Daniel Bates  <dbates@rim.com>
    215

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html

    r90441 r90496  
    11<!DOCTYPE html>
     2<!--
     3    The favicons are from the awesome famfamfam.com, which is the website of Mark James,
     4    a web developer from Birmingham, UK.
     5-->
    26<html>
    37<head>
    … …  
    4246}
    4347</style>
     48<link rel="icon" id="favicon" type="image/png" href="favicon-green.png">
    4449</head>
    4550<body>

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js

    r90441 r90496  
    1414}
    1515
     16function setIconState(hasFailures)
     17{
     18    var faviconURL = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png';
     19    $('#favicon').attr('href', faviconURL);
     20};
     21
    1622function fetchResults(onsuccess)
    1723{
    1824    results.fetchResultsByBuilder(config.builders, function(resultsByBuilder) {
    19         unexpectedFailures = ui.resultsByTest(results.unexpectedFailuresByTest(resultsByBuilder));
     25        var unexpectedFailures = ui.resultsByTest(results.unexpectedFailuresByTest(resultsByBuilder));
    2026        $('.failures').append(unexpectedFailures);
    2127        onsuccess();
    2228    });
     29    setIconState($('.failures').length);
    2330}
    2431

  • trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py

    r90441 r90496  
    4343        "results.js",
    4444        "ui.js",
     45        "favicon-green.png",
     46        "favicon-red.png",
    4547    ])
    4648
Note: See TracChangeset for help on using the changeset viewer.