Changeset 90548 in webkit


Ignore:
Timestamp:
Jul 7, 2011 12:44:42 AM (13 years ago)
Author:
eric@webkit.org
Message:

2011-07-07 Eric Seidel <eric@webkit.org>

Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=64056

Unreviewed.

I had written this unittest prior to landing my change, but
had named it qt_unitest.py, so it wasn't running (nor was
it added to my git repo).

Once I fixe the name of the unittest file, it was very easy
to fix the error in webkit.py (which already had a FIXME).

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
Location:
trunk/Tools
Files:
1 added
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r90547 r90548  
     12011-07-07  Eric Seidel  <eric@webkit.org>
     2
     3        Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
     4        https://bugs.webkit.org/show_bug.cgi?id=64056
     5
     6        Unreviewed.
     7
     8        I had written this unittest prior to landing my change, but
     9        had named it qt_unitest.py, so it wasn't running (nor was
     10        it added to my git repo).
     11
     12        Once I fixe the name of the unittest file, it was very easy
     13        to fix the error in webkit.py (which already had a FIXME).
     14
     15        * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added.
     16        * Scripts/webkitpy/layout_tests/port/webkit.py:
     17
    1182011-07-07  Eric Seidel  <eric@webkit.org>
    219
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py

    r90547 r90548  
    6262        return "DumpRenderTree"
    6363
    64     # FIXME: This is not a very useful default implementation, as its wrong for any
    65     # port which uses version-specific fallback (e.g. ['mac-leapard', 'mac']).
    66     # We should replace this with a smarter implementation shared by all ports.
     64    # FIXME: Eventually we should standarize port naming, and make this method smart enough
     65    # to use for all port configurations (including architectures, graphics types, etc).
    6766    def baseline_search_path(self):
    68         search_paths = [self.name()]
     67        search_paths = []
    6968        if self.get_option('webkit_test_runner'):
    70             search_paths.insert(0, self._wk2_port_name())
     69            search_paths.append(self._wk2_port_name())
     70        search_paths.append(self.name())
     71        if self.name() != self.port_name:
     72            search_paths.append(self.port_name)
    7173        return map(self._webkit_baseline_path, search_paths)
    7274
Note: See TracChangeset for help on using the changeset viewer.