Changeset 90551 in webkit

Timestamp:

Jul 7, 2011 3:29:19 AM (13 years ago)

Author:

Carlos Garcia Campos

Message:

2011-07-07 Carlos Garcia Campos <​cgarcia@igalia.com>

[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=63988

Reviewed by Martin Robinson.

• MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): (decidePolicyForNavigationAction): Ignore the action if a link is clicked with the middle buttonm and open the link in a new window. (browserWindowPolicyClientInit):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/gtk/BrowserWindow.c (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-07  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=63988
+
+        Reviewed by Martin Robinson.
+
+        * MiniBrowser/gtk/BrowserWindow.c:
+        (browserWindowConstructed):
+        (decidePolicyForNavigationAction): Ignore the action if a link is
+        clicked with the middle buttonm and open the link in a new window.
+        (browserWindowPolicyClientInit):
+
 2011-07-07  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/MiniBrowser/gtk/BrowserWindow.c

@@ -57 +57 @@
 static void browserWindowLoaderClientInit(BrowserWindow*);
 static void browserWindowUIClientInit(BrowserWindow*);
+static void browserWindowPolicyClientInit(BrowserWindow*);
 
 static gint windowCount = 0;
@@ -184 +185 @@
     browserWindowLoaderClientInit(window);
     browserWindowUIClientInit(window);
+    browserWindowPolicyClientInit(window);
 }
 
@@ -655 +657 @@
 }
 
+static void decidePolicyForNavigationAction(WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, WKURLRequestRef request, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo)
+{
+    if (navigationType != kWKFrameNavigationTypeLinkClicked || mouseButton != kWKEventMouseButtonMiddleButton) {
+        WKFramePolicyListenerUse(listener);
+        return;
+    }
+
+    WKViewRef webView = WKViewCreate(WKPageGetContext(page), 0);
+    GtkWidget *window = browser_window_new(webView);
+    WKURLRef url = WKURLRequestCopyURL(request);
+    WKPageLoadURL(WKViewGetPage(webView), url);
+    WKRelease(url);
+    gtk_widget_grab_focus(GTK_WIDGET(webView));
+    gtk_widget_show(window);
+
+    WKFramePolicyListenerIgnore(listener);
+}
+
+static void browserWindowPolicyClientInit(BrowserWindow* window)
+{
+    WKPagePolicyClient policyClient = {
+        kWKPagePolicyClientCurrentVersion,
+        window, /* clientInfo */
+        decidePolicyForNavigationAction,
+        0,      /* decidePolicyForNewWindowAction */
+        0,      /* decidePolicyForResponse */
+        0       /* unableToImplementPolicy */
+    };
+    WKPageSetPagePolicyClient(WKViewGetPage(window->webView), &policyClient);
+}
+
 // Public API.
 GtkWidget* browser_window_new(WKViewRef view)