Changeset 90553 in webkit


Ignore:
Timestamp:
Jul 7, 2011 3:47:03 AM (13 years ago)
Author:
vsevik@chromium.org
Message:

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
https://bugs.webkit.org/show_bug.cgi?id=63999

Added clear cache and cookies tests. Since no port currently supports
this functionality, the tests are disabled.

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/network-clear-cache-expected.txt: Added.
  • http/tests/inspector/network/network-clear-cache.html-disabled: Added.
  • http/tests/inspector/network/network-clear-cookies-expected.txt: Added.
  • http/tests/inspector/network/network-clear-cookies.html-disabled: Added.
  • http/tests/inspector/network/resources/random-cached.php: Added.
  • http/tests/inspector/network/resources/set-cookie.php: Added.

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
https://bugs.webkit.org/show_bug.cgi?id=63999

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorClient.h: (WebCore::InspectorClient::clearBrowserCache): (WebCore::InspectorClient::clearBrowserCookies):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearBrowserCache): (WebCore::InspectorResourceAgent::clearBrowserCookies): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._clearBrowserCache): (WebInspector.NetworkPanel.prototype._clearBrowserCookies):
  • inspector/front-end/Settings.js:

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
https://bugs.webkit.org/show_bug.cgi?id=63999

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::clearBrowserCache): (WebKit::WebDevToolsAgentClient::clearBrowserCookies):
  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::clearBrowserCache): (WebKit::InspectorClientImpl::clearBrowserCookies):
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::clearBrowserCache): (WebKit::WebDevToolsAgentImpl::clearBrowserCookies):
  • src/WebDevToolsAgentImpl.h:
Location:
trunk
Files:
6 added
16 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r90552 r90553  
     12011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
     2
     3        Web Inspector: Add support for clearing cache and cookies from network panel.
     4        https://bugs.webkit.org/show_bug.cgi?id=63999
     5
     6        Added clear cache and cookies tests. Since no port currently supports
     7        this functionality, the tests are disabled.
     8
     9        Reviewed by Pavel Feldman.
     10
     11        * http/tests/inspector/network/network-clear-cache-expected.txt: Added.
     12        * http/tests/inspector/network/network-clear-cache.html-disabled: Added.
     13        * http/tests/inspector/network/network-clear-cookies-expected.txt: Added.
     14        * http/tests/inspector/network/network-clear-cookies.html-disabled: Added.
     15        * http/tests/inspector/network/resources/random-cached.php: Added.
     16        * http/tests/inspector/network/resources/set-cookie.php: Added.
     17
    1182011-07-07  Shinya Kawanaka  <shinyak@google.com>
    219
  • trunk/Source/WebCore/ChangeLog

    r90552 r90553  
     12011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
     2
     3        Web Inspector: Add support for clearing cache and cookies from network panel.
     4        https://bugs.webkit.org/show_bug.cgi?id=63999
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * English.lproj/localizedStrings.js:
     9        * inspector/Inspector.json:
     10        * inspector/InspectorClient.h:
     11        (WebCore::InspectorClient::clearBrowserCache):
     12        (WebCore::InspectorClient::clearBrowserCookies):
     13        * inspector/InspectorController.cpp:
     14        (WebCore::InspectorController::InspectorController):
     15        * inspector/InspectorResourceAgent.cpp:
     16        (WebCore::InspectorResourceAgent::clearBrowserCache):
     17        (WebCore::InspectorResourceAgent::clearBrowserCookies):
     18        (WebCore::InspectorResourceAgent::InspectorResourceAgent):
     19        * inspector/InspectorResourceAgent.h:
     20        (WebCore::InspectorResourceAgent::create):
     21        * inspector/front-end/NetworkPanel.js:
     22        (WebInspector.NetworkPanel.prototype._contextMenu):
     23        (WebInspector.NetworkPanel.prototype._clearBrowserCache):
     24        (WebInspector.NetworkPanel.prototype._clearBrowserCookies):
     25        * inspector/front-end/Settings.js:
     26
    1272011-07-07  Shinya Kawanaka  <shinyak@google.com>
    228
  • trunk/Source/WebCore/inspector/Inspector.json

    r90460 r90553  
    500500                    { "name": "base64Encoded", "type": "boolean", "description": "True, if content was served as base64." }
    501501                ]
     502            },
     503            {
     504                "name": "clearBrowserCache",
     505                "description": "Clears browser cache."
     506            },
     507            {
     508                "name": "clearBrowserCookies",
     509                "description": "Clears browser cookies."
    502510            }
    503511        ],
  • trunk/Source/WebCore/inspector/InspectorClient.h

    r82810 r90553  
    5353    virtual void updateInspectorStateCookie(const String&) { };
    5454
     55    virtual void clearBrowserCache() { }
     56    virtual void clearBrowserCookies() { }
     57
    5558    bool doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message);
    5659};
  • trunk/Source/WebCore/inspector/InspectorController.cpp

    r90389 r90553  
    102102    , m_applicationCacheAgent(adoptPtr(new InspectorApplicationCacheAgent(m_instrumentingAgents.get(), page)))
    103103#endif
    104     , m_resourceAgent(InspectorResourceAgent::create(m_instrumentingAgents.get(), m_pageAgent.get(), m_state.get()))
     104    , m_resourceAgent(InspectorResourceAgent::create(m_instrumentingAgents.get(), m_pageAgent.get(), inspectorClient, m_state.get()))
    105105    , m_runtimeAgent(adoptPtr(new PageRuntimeAgent(m_injectedScriptManager.get(), page)))
    106106    , m_consoleAgent(adoptPtr(new InspectorConsoleAgent(m_instrumentingAgents.get(), m_inspectorAgent.get(), m_state.get(), m_injectedScriptManager.get(), m_domAgent.get())))
  • trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp

    r90389 r90553  
    4242#include "FrameLoader.h"
    4343#include "HTTPHeaderMap.h"
     44#include "InspectorClient.h"
    4445#include "InspectorFrontend.h"
    4546#include "InspectorFrontendChannel.h"
     
    475476}
    476477
     478void InspectorResourceAgent::clearBrowserCache(ErrorString*)
     479{
     480    m_client->clearBrowserCache();
     481}
     482
     483void InspectorResourceAgent::clearBrowserCookies(ErrorString*)
     484{
     485    m_client->clearBrowserCookies();
     486}
     487
    477488void InspectorResourceAgent::mainFrameNavigated(DocumentLoader* loader)
    478489{
     
    480491}
    481492
    482 InspectorResourceAgent::InspectorResourceAgent(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InspectorState* state)
     493InspectorResourceAgent::InspectorResourceAgent(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InspectorClient* client, InspectorState* state)
    483494    : m_instrumentingAgents(instrumentingAgents)
    484495    , m_pageAgent(pageAgent)
     496    , m_client(client)
    485497    , m_state(state)
    486498    , m_resourcesData(adoptPtr(new NetworkResourcesData()))
  • trunk/Source/WebCore/inspector/InspectorResourceAgent.h

    r90389 r90553  
    5252class Frame;
    5353class InspectorArray;
     54class InspectorClient;
    5455class InspectorFrontend;
    5556class InspectorFrontendProxy;
     
    7576class InspectorResourceAgent : public RefCounted<InspectorResourceAgent> {
    7677public:
    77     static PassRefPtr<InspectorResourceAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InspectorState* state)
     78    static PassRefPtr<InspectorResourceAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InspectorClient* client, InspectorState* state)
    7879    {
    79         return adoptRef(new InspectorResourceAgent(instrumentingAgents, pageAgent, state));
     80        return adoptRef(new InspectorResourceAgent(instrumentingAgents, pageAgent, client, state));
    8081    }
    8182
     
    125126    void clearCache(ErrorString*, const String* const optionalPreservedLoaderId);
    126127
     128    void clearBrowserCache(ErrorString*);
     129    void clearBrowserCookies(ErrorString*);
     130
    127131private:
    128     InspectorResourceAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorState*);
     132    InspectorResourceAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorClient*, InspectorState*);
    129133
    130134    bool isBackgroundEventsCollectionEnabled();
     
    134138    InstrumentingAgents* m_instrumentingAgents;
    135139    InspectorPageAgent* m_pageAgent;
     140    InspectorClient* m_client;
    136141    InspectorState* m_state;
    137142    InspectorFrontend::Network* m_frontend;
  • trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

    r90393 r90553  
    994994        }
    995995
     996        if (Preferences.canClearCacheAndCookies) {
     997            contextMenu.appendSeparator();
     998            contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Clear browser cache" : "Clear Browser Cache"), this._clearBrowserCache.bind(this));
     999            contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Clear browser cookies" : "Clear Browser Cookies"), this._clearBrowserCookies.bind(this));
     1000        }
     1001
    9961002        contextMenu.show(event);
    9971003    },
     
    10381044        var har = (new WebInspector.HAREntry(resource)).build();
    10391045        InspectorFrontendHost.saveAs(resource.displayName + ".har", JSON.stringify(har));
     1046    },
     1047
     1048    _clearBrowserCache: function(event)
     1049    {
     1050        if (confirm(WebInspector.UIString("Are you sure you want to clear browser cache?")))
     1051            NetworkAgent.clearBrowserCache();
     1052    },
     1053
     1054    _clearBrowserCookies: function(event)
     1055    {
     1056        if (confirm(WebInspector.UIString("Are you sure you want to clear browser cookies?")))
     1057            NetworkAgent.clearBrowserCookies();
    10401058    },
    10411059
  • trunk/Source/WebCore/inspector/front-end/Settings.js

    r90387 r90553  
    5454    useLowerCaseMenuTitlesOnWindows: false,
    5555    canInspectWorkers: false,
     56    canClearCacheAndCookies: false
    5657}
    5758
  • trunk/Source/WebKit/chromium/ChangeLog

    r90540 r90553  
     12011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
     2
     3        Web Inspector: Add support for clearing cache and cookies from network panel.
     4        https://bugs.webkit.org/show_bug.cgi?id=63999
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * public/WebDevToolsAgentClient.h:
     9        (WebKit::WebDevToolsAgentClient::clearBrowserCache):
     10        (WebKit::WebDevToolsAgentClient::clearBrowserCookies):
     11        * src/InspectorClientImpl.cpp:
     12        (WebKit::InspectorClientImpl::clearBrowserCache):
     13        (WebKit::InspectorClientImpl::clearBrowserCookies):
     14        * src/InspectorClientImpl.h:
     15        * src/WebDevToolsAgentImpl.cpp:
     16        (WebKit::WebDevToolsAgentImpl::clearBrowserCache):
     17        (WebKit::WebDevToolsAgentImpl::clearBrowserCookies):
     18        * src/WebDevToolsAgentImpl.h:
     19
    1202011-07-06  Adam Barth  <abarth@webkit.org>
    221
  • trunk/Source/WebKit/chromium/public/WebDevToolsAgentClient.h

    r81758 r90553  
    6060    virtual bool exposeV8DebuggerProtocol() { return false; }
    6161
     62    virtual void clearBrowserCache() { }
     63    virtual void clearBrowserCookies() { }
     64
    6265protected:
    6366    ~WebDevToolsAgentClient() { }
  • trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp

    r77617 r90553  
    9595}
    9696
     97void InspectorClientImpl::clearBrowserCache()
     98{
     99    if (WebDevToolsAgentImpl* agent = devToolsAgent())
     100        agent->clearBrowserCache();
     101}
     102
     103void InspectorClientImpl::clearBrowserCookies()
     104{
     105    if (WebDevToolsAgentImpl* agent = devToolsAgent())
     106        agent->clearBrowserCookies();
     107}
     108
    97109WebDevToolsAgentImpl* InspectorClientImpl::devToolsAgent()
    98110{
  • trunk/Source/WebKit/chromium/src/InspectorClientImpl.h

    r77617 r90553  
    5757
    5858    virtual void updateInspectorStateCookie(const WTF::String&);
     59
     60    virtual void clearBrowserCache();
     61    virtual void clearBrowserCookies();
    5962private:
    6063    WebDevToolsAgentImpl* devToolsAgent();
  • trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp

    r90017 r90553  
    307307}
    308308
     309void WebDevToolsAgentImpl::clearBrowserCache()
     310{
     311    m_client->clearBrowserCache();
     312}
     313
     314void WebDevToolsAgentImpl::clearBrowserCookies()
     315{
     316    m_client->clearBrowserCookies();
     317}
     318
    309319void WebDevToolsAgentImpl::setAgentIdentifierPrefix(const WebString& prefix)
    310320{
  • trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h

    r90017 r90553  
    9292    virtual bool sendMessageToFrontend(const WTF::String&);
    9393
     94    virtual void clearBrowserCache();
     95    virtual void clearBrowserCookies();
     96
    9497    int hostId() { return m_hostId; }
    9598
Note: See TracChangeset for help on using the changeset viewer.