Changeset 90555 in webkit

Timestamp:

Jul 7, 2011 4:33:41 AM (13 years ago)

Author:

vsevik@chromium.org

Message:

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
​https://bugs.webkit.org/show_bug.cgi?id=63936

Reviewed by Pavel Feldman.

• http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt: Added.
• http/tests/inspector/resource-tree/resource-tree-non-unique-url.html: Added.
• http/tests/inspector/resource-tree/resource-tree-test.js: (initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
• http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html: Added.
• http/tests/inspector/resource-tree/resources/styles-non-unique-url.css: Added. (body):

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
​https://bugs.webkit.org/show_bug.cgi?id=63936

Reviewed by Pavel Feldman.

Test: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html

• inspector/front-end/ResourcesPanel.js: (WebInspector.FrameTreeElement.prototype.appendResource):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt (added)
• LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url.html (added)
• LayoutTests/http/tests/inspector/resource-tree/resource-tree-test.js (modified) (1 diff)
• LayoutTests/http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html (added)
• LayoutTests/http/tests/inspector/resource-tree/resources/styles-non-unique-url.css (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/ResourcesPanel.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
+        https://bugs.webkit.org/show_bug.cgi?id=63936
+
+        Reviewed by Pavel Feldman.
+
+        * http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt: Added.
+        * http/tests/inspector/resource-tree/resource-tree-non-unique-url.html: Added.
+        * http/tests/inspector/resource-tree/resource-tree-test.js:
+        (initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
+        * http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html: Added.
+        * http/tests/inspector/resource-tree/resources/styles-non-unique-url.css: Added.
+        (body):
+
 2011-07-07  Philippe Normand  <pnormand@igalia.com>
 

trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-test.js

@@ -52 +52 @@
     function dump(treeItem, prefix)
     {
+        // We don't need to print the bubbles content here.
+        if (typeof(treeItem._resetBubble) === "function")
+            treeItem._resetBubble();
+
         InspectorTest.addResult(prefix + treeItem.listItemElement.textContent);
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
+        https://bugs.webkit.org/show_bug.cgi?id=63936
+
+        Reviewed by Pavel Feldman.
+
+        Test: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
+
+        * inspector/front-end/ResourcesPanel.js:
+        (WebInspector.FrameTreeElement.prototype.appendResource):
+
 2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js

@@ -1115 +1115 @@
     appendResource: function(resource)
     {
-        if (this._treeElementForResource[resource.url])
-            return;
-
         var categoryName = resource.category.name;
         var categoryElement = resource.category === WebInspector.resourceCategories.documents ? this : this._categoryElements[categoryName];