Changeset 90612 in webkit

Timestamp:

Jul 7, 2011 11:41:26 PM (13 years ago)

Author:

yutak@chromium.org

Message:

WebSocket: Clear cookies after test in httponly-cookie.pl
​https://bugs.webkit.org/show_bug.cgi?id=64145

Reviewed by Kent Tamura.

This test leaks cookies, which would cause a test failure if we put
a copy of this test under http/tests/websocket/tests.

To avoid this issue, cookies should be removed before the test ends.

• http/tests/websocket/tests/hixie76/httponly-cookie.pl:

After the test, send an XHR request to itself with a query parameter,
which erases cookies used in this test by setting "Max-Age=0".

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/websocket/tests/hixie76/httponly-cookie.pl (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-07  Yuta Kitamura  <yutak@chromium.org>
+
+        WebSocket: Clear cookies after test in httponly-cookie.pl
+        https://bugs.webkit.org/show_bug.cgi?id=64145
+
+        Reviewed by Kent Tamura.
+
+        This test leaks cookies, which would cause a test failure if we put
+        a copy of this test under http/tests/websocket/tests.
+
+        To avoid this issue, cookies should be removed before the test ends.
+
+        * http/tests/websocket/tests/hixie76/httponly-cookie.pl:
+        After the test, send an XHR request to itself with a query parameter,
+        which erases cookies used in this test by setting "Max-Age=0".
+
 2011-07-07  Kent Tamura  <tkent@chromium.org>
 

trunk/LayoutTests/http/tests/websocket/tests/hixie76/httponly-cookie.pl

@@ -1 +1 @@
 #!/usr/bin/perl -wT
 use strict;
+
+if ($ENV{"QUERY_STRING"} eq "clear=1") {
+    print "Content-Type: text/plain\r\n";
+    print "Set-Cookie: WK-websocket-test=0; Max-Age=0\r\n";
+    print "Set-Cookie: WK-websocket-test-httponly=0; HttpOnly; Max-Age=0\r\n";
+    print "\r\n";
+    print "Cookies are cleared.";
+    exit;
+}
 
 print "Content-Type: text/html\r\n";
@@ -27 +36 @@
 }
 
+function clearCookies()
+{
+    var xhr = new XMLHttpRequest();
+    xhr.open("GET", "httponly-cookie.pl?clear=1", false);
+    xhr.send(null);
+}
+
 var ws = new WebSocket("ws://127.0.0.1:8880/websocket/tests/hixie76/echo-cookie");
 ws.onopen = function() {
@@ -39 +55 @@
     cookie = normalizeCookie(cookie);
     shouldBe("cookie", '"WK-websocket-test-httponly=1; WK-websocket-test=1"');
+    clearCookies();
     finishJSTest();
 };