Changeset 90636 in webkit

Timestamp:

Jul 8, 2011 8:58:29 AM (13 years ago)

Author:

abarth@webkit.org

Message:

sheriffbot is too spammy in IRC
​https://bugs.webkit.org/show_bug.cgi?id=64153

Reviewed by Eric Seidel.

Reporting failures in IRC worked well when the tree was greener than it
is today. Nowadays, this feature mostly just results in spam about
false positives. If we reach a greener state, we can bring this code
back.

(Another possibility is to restrict this feature to builder bots,
rather than including testers, as we did before this patch.)

• Scripts/webkitpy/tool/commands/sheriffbot.py:
• Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/sheriffbot.py (modified) (3 diffs)
• Scripts/webkitpy/tool/commands/sheriffbot_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-08  Adam Barth  <abarth@webkit.org>
+
+        sheriffbot is too spammy in IRC
+        https://bugs.webkit.org/show_bug.cgi?id=64153
+
+        Reviewed by Eric Seidel.
+
+        Reporting failures in IRC worked well when the tree was greener than it
+        is today.  Nowadays, this feature mostly just results in spam about
+        false positives.  If we reach a greener state, we can bring this code
+        back.
+
+        (Another possibility is to restrict this feature to builder bots,
+        rather than including testers, as we did before this patch.)
+
+        * Scripts/webkitpy/tool/commands/sheriffbot.py:
+        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
+
 2011-07-08  Adam Roben  <aroben@apple.com>
 

trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py

@@ -44 +44 @@
     ]
 
-    def _update(self):
-        self.run_webkit_patch(["update", "--force-clean", "--quiet"])
-
     # AbstractQueue methods
 
@@ -63 +60 @@
     def next_work_item(self):
         self._irc_bot.process_pending_messages()
-        self._update()
-
-        # FIXME: We need to figure out how to provoke_flaky_builders.
-
-        failure_map = self._tool.buildbot.failure_map()
-        failure_map.filter_out_old_failures(self._is_old_failure)
-        if failure_map.is_empty():
-            return None
-        return failure_map
+        return
 
     def should_proceed_with_work_item(self, failure_map):
@@ -78 +67 @@
 
     def process_work_item(self, failure_map):
-        failing_revisions = failure_map.failing_revisions()
-        number_of_failing_revisions = len(failing_revisions)
-        for revision in failing_revisions:
-            builders = failure_map.builders_failing_for(revision)
-            try:
-                commit_info = self._tool.checkout().commit_info_for_revision(revision)
-                if not commit_info:
-                    print "FAILED to fetch CommitInfo for r%s, likely missing ChangeLog" % revision
-                    continue
-                self._sheriff.post_irc_warning(commit_info, builders)
-                # We used to post on bugs, but it was too spammy.
-            finally:
-                for builder in builders:
-                    self._tool.status_server.update_svn_revision(revision, builder.name())
-        self._sheriff.post_irc_summary(failure_map)
         return True
 

trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py

@@ -35 +35 @@
 
 class SheriffBotTest(QueuesTest):
-    builder1 = MockBuilder("Builder1")
-    builder2 = MockBuilder("Builder2")
-
-    def test_sheriff_bot(self):
-        tool = MockTool()
-        mock_work_item = MockFailureMap(tool.buildbot)
-        expected_stderr = {
-            "begin_work_queue": self._default_begin_work_queue_stderr("sheriff-bot", tool.scm().checkout_root),
-            "next_work_item": "",
-            "process_work_item": """MOCK: irc.post: abarth, darin, eseidel: http://trac.webkit.org/changeset/29837 might have broken Builder1
-MOCK: irc.post: New failures: mock-test-1
-""",
-            "handle_unexpected_error": "Mock error message\n",
-        }
-        self.assert_queue_outputs(SheriffBot(), work_item=mock_work_item, expected_stderr=expected_stderr)
-
-    def test_many_failing_tests(self):
-        tool = MockTool()
-        mock_work_item = MockFailureMap(tool.buildbot)
-        mock_work_item.failing_tests = lambda: set(["test1", "test2", "test3", "test4", "test5", "test6", "test7"])
-        expected_stderr = {
-            "begin_work_queue": self._default_begin_work_queue_stderr("sheriff-bot", tool.scm().checkout_root),
-            "next_work_item": "",
-            "process_work_item": """MOCK: irc.post: abarth, darin, eseidel: http://trac.webkit.org/changeset/29837 might have broken Builder1
-MOCK: irc.post: New failures: test1, test2, test3, test4, test5 (and 2 more...)
-""",
-            "handle_unexpected_error": "Mock error message\n",
-        }
-        self.assert_queue_outputs(SheriffBot(), work_item=mock_work_item, expected_stderr=expected_stderr)
+    pass  # No unittests as the moment.