Changeset 90648 in webkit


Ignore:
Timestamp:
Jul 8, 2011 11:47:49 AM (13 years ago)
Author:
Adam Roben
Message:

Ensure $CHANGE_LOG_EMAIL_ADDRESS is set when testing webkitpy's commit-log-editor integration

Fixes <http://webkit.org/b/64180> REGRESSION (r90564): test-webkitpy failing on multiple
bots due to commit-log-editor errors

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Set
$CHANGE_LOG_EMAIL_ADDRESS to the patch author's email address. This ensures that
commit-log-editor can find a value for the committer's email, and that the committer and
author email addresses match, which will prevent commit-log-editor from inserting a "Patch
by" line in the commit message.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r90647 r90648  
     12011-07-08  Adam Roben  <aroben@apple.com>
     2
     3        Ensure $CHANGE_LOG_EMAIL_ADDRESS is set when testing webkitpy's commit-log-editor integration
     4
     5        Fixes <http://webkit.org/b/64180> REGRESSION (r90564): test-webkitpy failing on multiple
     6        bots due to commit-log-editor errors
     7
     8        Reviewed by Adam Barth.
     9
     10        * Scripts/webkitpy/common/checkout/checkout_unittest.py:
     11        (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Set
     12        $CHANGE_LOG_EMAIL_ADDRESS to the patch author's email address. This ensures that
     13        commit-log-editor can find a value for the committer's email, and that the committer and
     14        author email addresses match, which will prevent commit-log-editor from inserting a "Patch
     15        by" line in the commit message.
     16
    1172011-07-08  Andreas Kling  <kling@webkit.org>
    218
  • trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py

    r90584 r90648  
    125125            # Note that we use a real Executive here, not a MockExecutive, so we can test that we're
    126126            # invoking commit-log-editor correctly.
     127            env = os.environ.copy()
     128            env['CHANGE_LOG_EMAIL_ADDRESS'] = 'vestbo@webkit.org'
     129            kwargs['env'] = env
    127130            return Executive().run_command(*args, **kwargs)
    128131
Note: See TracChangeset for help on using the changeset viewer.