Changeset 90672 in webkit


Ignore:
Timestamp:
Jul 8, 2011 4:35:46 PM (13 years ago)
Author:
Adam Roben
Message:

Make TestFailures's list of flaky tests look more like the list of non-flaky tests

Fixes <​http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
tests.
(#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
from here...
(#failure-history > li): ...to here.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
styling purposes.

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css

    r90153 r90672  
    2525}
    2626
    27 #failure-history {
     27#failure-history, #possibly-flaky-tests {
    2828    margin: 0;
    2929    padding: 0 0 0 15px;
    3030}
    3131
     32#failure-history > li, #possibly-flaky-tests > li {
     33    background-color: #f0f0f0;
     34    padding: 10px;
     35    margin-bottom: 10px;
     36}
     37
    3238#failure-history > li {
    33     background-color: #f0f0f0;
    34     padding: 10px 10px 10px 50px;
    35     margin-bottom: 10px;
     39    padding-left: 50px;
    3640}
    3741

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js

    r90639 r90672  
    502502        result.appendChild(flakyList);
    503503
     504        flakyList.id = 'possibly-flaky-tests';
     505
    504506        var self = this;
    505507        flakyList.appendChildren(sorted(flakyTests).map(function(testName) {

  • trunk/Tools/ChangeLog

    r90669 r90672  
     12011-07-08  Adam Roben  <aroben@apple.com>
     2
     3        Make TestFailures's list of flaky tests look more like the list of non-flaky tests
     4
     5        Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!
     6
     7        Reviewed by Daniel Bates.
     8
     9        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
     10        (#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
     11        tests.
     12        (#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
     13        from here...
     14        (#failure-history > li): ...to here.
     15
     16        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
     17        (ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
     18        styling purposes.
     19
    1202011-07-08  Jeffrey Pfau  <jpfau@apple.com>
    221
Note: See TracChangeset for help on using the changeset viewer.