Changeset 90686 in webkit

Timestamp:

Jul 9, 2011 12:47:10 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-07-09
Reviewed by Adam Roben.

[WebKit2] Forward focus events to windowless plugins on the windows port.
​https://bugs.webkit.org/show_bug.cgi?id=63251

No new tests. Covered by existing tests: plugins/mouse-events.html and
plugins/keyboard-events.html.

• WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformSetFocus):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-07-09  Noel Gordon  <noel.gordon@gmail.com>
+
+        Reviewed by Adam Roben.
+
+        [WebKit2] Forward focus events to windowless plugins on the windows port.
+        https://bugs.webkit.org/show_bug.cgi?id=63251
+
+        No new tests. Covered by existing tests: plugins/mouse-events.html and
+        plugins/keyboard-events.html.
+
+        * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
+        (WebKit::NetscapePlugin::platformSetFocus):
+
 2011-07-08  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp

@@ -309 +309 @@
 }
 
-void NetscapePlugin::platformSetFocus(bool)
-{
-    CurrentPluginSetter setCurrentPlugin(this);
-
-    notImplemented();
+void NetscapePlugin::platformSetFocus(bool hasFocus)
+{
+    CurrentPluginSetter setCurrentPlugin(this);
+
+    if (m_isWindowed)
+        return;
+
+    controller()->willSendEventToPlugin();
+
+    NPEvent npEvent;
+    npEvent.event = hasFocus ? WM_SETFOCUS : WM_KILLFOCUS;
+    npEvent.wParam = 0;
+    npEvent.lParam = 0;
+
+    NPP_HandleEvent(&npEvent);
 }