Changeset 90700 in webkit

Timestamp:

Jul 10, 2011 6:38:11 PM (13 years ago)

Author:

yuzo@google.com

Message:

Fix for Bug 63968 - Add comment to explain Vector usage in FontCache::purgeInactiveFontData
​https://bugs.webkit.org/show_bug.cgi?id=63968

Reviewed by Dan Bernstein.

No new tests because this changes comments only.

• platform/graphics/FontCache.cpp:

(WebCore::FontCache::purgeInactiveFontData): Add explanation why SimpleFontData is not deleted in the iteration loop.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/FontCache.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-10  Yuzo Fujishima  <yuzo@google.com>
+
+        Fix for Bug 63968 - Add comment to explain Vector usage in FontCache::purgeInactiveFontData
+        https://bugs.webkit.org/show_bug.cgi?id=63968
+
+        Reviewed by Dan Bernstein.
+
+        No new tests because this changes comments only.
+
+        * platform/graphics/FontCache.cpp:
+        (WebCore::FontCache::purgeInactiveFontData): Add explanation why SimpleFontData is not deleted in the iteration loop.
+
 2011-07-10  Emil A Eklund  <eae@chromium.org>
 

trunk/Source/WebCore/platform/graphics/FontCache.cpp

@@ -346 +346 @@
         const SimpleFontData* fontData = *it.get();
         gFontDataCache->remove(fontData->platformData());
+        // We should not delete SimpleFontData here because deletion can modify gInactiveFontData. See http://trac.webkit.org/changeset/44011
         fontDataToDelete.append(fontData);
     }