Changeset 90765 in webkit

Timestamp:

Jul 11, 2011 11:20:23 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Patch by Young Han Lee <​joybro@company100.net> on 2011-07-11
Reviewed by Simon Fraser.

Transition LayoutTest using pause API shows wrong result if it tries to pause a transition after its delay time.
​https://bugs.webkit.org/show_bug.cgi?id=63859

The existing code to set the m_startTime haven't worked because
the animation is not the right state to accept the start event.
This patch just sets the values directly instead of using event.

Source/WebCore:

Test: transitions/delay.html

• page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

LayoutTests:

• transitions/delay-expected.txt: Added.
• transitions/delay.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/transitions/delay-expected.txt (added)
• LayoutTests/transitions/delay.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/animation/AnimationBase.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-11  Young Han Lee  <joybro@company100.net>
+
+        Reviewed by Simon Fraser.
+
+        Transition LayoutTest using pause API shows wrong result if it tries to pause a transition after its delay time.
+        https://bugs.webkit.org/show_bug.cgi?id=63859
+
+        The existing code to set the m_startTime haven't worked because 
+        the animation is not the right state to accept the start event. 
+        This patch just sets the values directly instead of using event.
+
+        * transitions/delay-expected.txt: Added.
+        * transitions/delay.html: Added.
+
 2011-07-11  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-11  Young Han Lee  <joybro@company100.net>
+
+        Reviewed by Simon Fraser.
+
+        Transition LayoutTest using pause API shows wrong result if it tries to pause a transition after its delay time.
+        https://bugs.webkit.org/show_bug.cgi?id=63859
+
+        The existing code to set the m_startTime haven't worked because 
+        the animation is not the right state to accept the start event. 
+        This patch just sets the values directly instead of using event.
+
+        Test: transitions/delay.html
+
+        * page/animation/AnimationBase.cpp:
+        (WebCore::AnimationBase::freezeAtTime):
+
 2011-07-11  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/page/animation/AnimationBase.cpp

@@ -1444 +1444 @@
 
     if (!m_startTime) {
-        // If we haven't started yet, just generate the start event now
-        m_compAnim->animationController()->receivedStartTimeResponse(currentTime());
+        // If we haven't started yet, make it as if we started.
+        m_animState = AnimationStateStartWaitResponse;
+        onAnimationStartResponse(currentTime());
     }