Changeset 90778 in webkit


Ignore:
Timestamp:
Jul 11, 2011 12:20:49 PM (13 years ago)
Author:
Adam Roben
Message:

Don't count leaks as test failures on TestFailures's front page

As a bonus, this patch adds our first unit test.

Fixes <​http://webkit.org/b/64303> REGRESSION (r90489): TestFailures page says far more tests
are failing on the Leaks bot than actually are

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Exclude lines containing "leak" when summing
failure counts.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added. Contains a simple test to show that leaks aren't counted as test failures.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Added. This is the test harness.

Location:
trunk/Tools
Files:
2 added
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js

    r90504 r90778  
    143143                if (!match)
    144144                    return sum;
    145                 // Don't count new tests or passes as failures.
    146                 if (outputLine.contains('were new') || outputLine.contains('new passes'))
     145                // Don't count leaks, new tests, or passes as failures.
     146                if (outputLine.contains('leak') || outputLine.contains('were new') || outputLine.contains('new passes'))
    147147                    return sum;
    148148                return sum + parseInt(match[1], 10);

  • trunk/Tools/ChangeLog

    r90776 r90778  
     12011-07-11  Adam Roben  <aroben@apple.com>
     2
     3        Don't count leaks as test failures on TestFailures's front page
     4
     5        As a bonus, this patch adds our first unit test.
     6
     7        Fixes <http://webkit.org/b/64303> REGRESSION (r90489): TestFailures page says far more tests
     8        are failing on the Leaks bot than actually are
     9
     10        Reviewed by Adam Barth.
     11
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
     13        (Builder.prototype.getNumberOfFailingTests): Exclude lines containing "leak" when summing
     14        failure counts.
     15
     16        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
     17        Added. Contains a simple test to show that leaks aren't counted as test failures.
     18
     19        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
     20        Added. This is the test harness.
     21
    1222011-06-14  Mike Stegeman  <mrstegeman@gmail.com>
    223
Note: See TracChangeset for help on using the changeset viewer.