Changeset 90801 in webkit


Ignore:
Timestamp:
Jul 11, 2011 6:26:12 PM (13 years ago)
Author:
yutak@chromium.org
Message:

WebSocket: Remove WebSocket tests that do not apply to hybi protocol
​https://bugs.webkit.org/show_bug.cgi?id=64288

Reviewed by Kent Tamura.

Remove tests from http/tests/websocket/tests/hybi that are not meaningful in terms of
the hybi protocol. The most recent WebSocket protocol draft is available at
<​http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10>, and referred as
"hybi-10" here.

  • http/tests/websocket/tests/hybi/error-detect-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/error-detect.html: Removed.

Hybi protocol has a completely different scheme of representing frame types.
Additionally, hybi-10 no longer fires "error" events (which invoke "onerror" handler).

  • http/tests/websocket/tests/hybi/fixed-origin_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer.html: Removed.

Variable-length encoding (which is used to represent frame length in hixie-76) is no longer
used in hybi-10.

  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/frame-length-overflow-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/frame-length-overflow.html: Removed. Ditto.
  • http/tests/websocket/tests/hybi/frame-length-overflow_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/frame-length-skip-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/frame-length-skip.html: Removed.

There are two ways to indicate the length of a frame in hixie-76 protocol, but
hybi-10 has only one method (length-prefixed frames). Skipping unwanted frames will
be covered by other tests that will be added in a later patch.

  • http/tests/websocket/tests/hybi/frame-length-skip_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin.html: Removed.

In hybi-10, servers no longer returns Origin header in handshake response, and clients
are not required to validate this value.

  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch.html: Removed.

In hybi-10, clients are not required to (and must not) compare the values of subprotocols
in client's request and server's response.

  • http/tests/websocket/tests/hybi/unknown-frame-type_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query.html: Removed.

In hybi-10, servers do not provide "Sec-WebSocket-Location" header, and clients are not required
to validate this value.

  • http/tests/websocket/tests/hybi/websocket-protocol-ignored-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/websocket-protocol-ignored.html: Removed.

Same as handshake-fail-by-sub-protocol-mismatch.html.

Location:
trunk/LayoutTests
Files:
21 deleted
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r90800 r90801  
     12011-07-11  Yuta Kitamura  <yutak@chromium.org>
     2
     3        WebSocket: Remove WebSocket tests that do not apply to hybi protocol
     4        https://bugs.webkit.org/show_bug.cgi?id=64288
     5
     6        Reviewed by Kent Tamura.
     7
     8        Remove tests from http/tests/websocket/tests/hybi that are not meaningful in terms of
     9        the hybi protocol. The most recent WebSocket protocol draft is available at
     10        <http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10>, and referred as
     11        "hybi-10" here.
     12
     13        * http/tests/websocket/tests/hybi/error-detect-expected.txt: Removed.
     14        * http/tests/websocket/tests/hybi/error-detect.html: Removed.
     15        Hybi protocol has a completely different scheme of representing frame types.
     16        Additionally, hybi-10 no longer fires "error" events (which invoke "onerror" handler).
     17        * http/tests/websocket/tests/hybi/fixed-origin_wsh.py: Removed.
     18        * http/tests/websocket/tests/hybi/frame-length-longer-than-buffer-expected.txt: Removed.
     19        * http/tests/websocket/tests/hybi/frame-length-longer-than-buffer.html: Removed.
     20        Variable-length encoding (which is used to represent frame length in hixie-76) is no longer
     21        used in hybi-10.
     22        * http/tests/websocket/tests/hybi/frame-length-longer-than-buffer_wsh.py: Removed.
     23        * http/tests/websocket/tests/hybi/frame-length-overflow-expected.txt: Removed.
     24        * http/tests/websocket/tests/hybi/frame-length-overflow.html: Removed. Ditto.
     25        * http/tests/websocket/tests/hybi/frame-length-overflow_wsh.py: Removed.
     26        * http/tests/websocket/tests/hybi/frame-length-skip-expected.txt: Removed.
     27        * http/tests/websocket/tests/hybi/frame-length-skip.html: Removed.
     28        There are two ways to indicate the length of a frame in hixie-76 protocol, but
     29        hybi-10 has only one method (length-prefixed frames). Skipping unwanted frames will
     30        be covered by other tests that will be added in a later patch.
     31        * http/tests/websocket/tests/hybi/frame-length-skip_wsh.py: Removed.
     32        * http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin-expected.txt: Removed.
     33        * http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin.html: Removed.
     34        In hybi-10, servers no longer returns Origin header in handshake response, and clients
     35        are not required to validate this value.
     36        * http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed.
     37        * http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch.html: Removed.
     38        In hybi-10, clients are not required to (and must not) compare the values of subprotocols
     39        in client's request and server's response.
     40        * http/tests/websocket/tests/hybi/unknown-frame-type_wsh.py: Removed.
     41        * http/tests/websocket/tests/hybi/url-with-query-for-no-query-expected.txt: Removed.
     42        * http/tests/websocket/tests/hybi/url-with-query-for-no-query.html: Removed.
     43        In hybi-10, servers do not provide "Sec-WebSocket-Location" header, and clients are not required
     44        to validate this value.
     45        * http/tests/websocket/tests/hybi/websocket-protocol-ignored-expected.txt: Removed.
     46        * http/tests/websocket/tests/hybi/websocket-protocol-ignored.html: Removed.
     47        Same as handshake-fail-by-sub-protocol-mismatch.html.
     48
    1492011-07-11  Ryosuke Niwa  <rniwa@webkit.org>
    250
Note: See TracChangeset for help on using the changeset viewer.