Changeset 90818 in webkit

Timestamp:

Jul 12, 2011 7:49:33 AM (13 years ago)

Author:

podivilov@chromium.org

Message:

Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=64353

Reviewed by Pavel Feldman.

Source/WebCore:

• inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.afterTextChanged):
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrame.prototype.doubleClick):
(WebInspector.SourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):

LayoutTests:

• inspector/debugger/live-edit.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/debugger/live-edit.html (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/SourceFrame.js (modified) (8 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-12  Pavel Podivilov  <podivilov@chromium.org>
+
+        Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
+        https://bugs.webkit.org/show_bug.cgi?id=64353
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/debugger/live-edit.html:
+
 2011-07-12  Adam Roben  <aroben@apple.com>
 

trunk/LayoutTests/inspector/debugger/live-edit.html

@@ -113 +113 @@
         InspectorTest.addSniffer(WebInspector.debuggerModel, "_didEditScriptSource", callback);
         sourceFrame._textViewer._mainPanel.readOnly = false;
-        sourceFrame._beforeTextChanged();
+        sourceFrame.beforeTextChanged();
         var oldRange, newRange;
         var lines = sourceFrame._textModel._lines;
@@ -127 +127 @@
             break;
         }
-        sourceFrame._afterTextChanged(oldRange, newRange);
+        sourceFrame.afterTextChanged(oldRange, newRange);
         sourceFrame._textViewer._commitEditing();
     }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-12  Pavel Podivilov  <podivilov@chromium.org>
+
+        Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
+        https://bugs.webkit.org/show_bug.cgi?id=64353
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/SourceFrame.js:
+        (WebInspector.SourceFrame.prototype.beforeTextChanged):
+        (WebInspector.SourceFrame.prototype.afterTextChanged):
+        (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
+        (WebInspector.SourceFrame.prototype.suggestedFileName):
+        (WebInspector.SourceFrame.prototype.doubleClick):
+        (WebInspector.SourceFrame.prototype.cancelEditing):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):
+
 2011-07-12  Andrey Kosyakov  <caseq@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/SourceFrame.js

@@ -238 +238 @@
     },
 
-    _beforeTextChanged: function()
+    beforeTextChanged: function()
     {
         if (!this._viewerState) {
@@ -249 +249 @@
     },
 
-    _afterTextChanged: function(oldRange, newRange)
+    afterTextChanged: function(oldRange, newRange)
     {
         if (!oldRange || !newRange)
@@ -594 +594 @@
     },
 
-    _populateLineGutterContextMenu: function(lineNumber, contextMenu)
+    populateLineGutterContextMenu: function(lineNumber, contextMenu)
     {
         contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Continue to here" : "Continue to Here"), this._delegate.continueToLine.bind(this._delegate, lineNumber));
@@ -639 +639 @@
     },
 
-    _populateTextAreaContextMenu: function(contextMenu)
-    {
-    },
-
-    _suggestedFileName: function()
+    populateTextAreaContextMenu: function(contextMenu)
+    {
+    },
+
+    suggestedFileName: function()
     {
         return this._delegate.suggestedFileName();
@@ -873 +873 @@
     },
 
-    _doubleClick: function(lineNumber)
+    doubleClick: function(lineNumber)
     {
         if (!this._delegate.canEditScriptSource())
@@ -884 +884 @@
     },
 
-    _commitEditing: function()
+    commitEditing: function()
     {
         if (!this._viewerState) {
@@ -932 +932 @@
     },
 
-    _cancelEditing: function()
+    cancelEditing: function()
     {
         this._restoreViewerState();
@@ -958 +958 @@
     doubleClick: function(lineNumber)
     {
-        this._sourceFrame._doubleClick(lineNumber);
+        this._sourceFrame.doubleClick(lineNumber);
     },
 
     beforeTextChanged: function()
     {
-        this._sourceFrame._beforeTextChanged();
+        this._sourceFrame.beforeTextChanged();
     },
 
     afterTextChanged: function(oldRange, newRange)
     {
-        this._sourceFrame._afterTextChanged(oldRange, newRange);
+        this._sourceFrame.afterTextChanged(oldRange, newRange);
     },
 
     commitEditing: function()
     {
-        this._sourceFrame._commitEditing();
+        this._sourceFrame.commitEditing();
     },
 
     cancelEditing: function()
     {
-        this._sourceFrame._cancelEditing();
+        this._sourceFrame.cancelEditing();
     },
 
     populateLineGutterContextMenu: function(lineNumber, contextMenu)
     {
-        this._sourceFrame._populateLineGutterContextMenu(lineNumber, contextMenu);
+        this._sourceFrame.populateLineGutterContextMenu(lineNumber, contextMenu);
     },
 
     populateTextAreaContextMenu: function(contextMenu)
     {
-        this._sourceFrame._populateTextAreaContextMenu(contextMenu);
+        this._sourceFrame.populateTextAreaContextMenu(contextMenu);
     },
 
     suggestedFileName: function()
     {
-        return this._sourceFrame._suggestedFileName();
+        return this._sourceFrame.suggestedFileName();
     }
 };