Changeset 90864 in webkit

Timestamp:

Jul 12, 2011 3:35:28 PM (13 years ago)

Author:

abarth@webkit.org

Message:

cr-linux-ews should run pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=64394

Reviewed by Ojan Vafai.

This patch enabled pixel test on the cr-linux-ews. Running a quick
test on the bots, it looks like we have five pixel failures, related to
some missing fonts. I've also made the bots skip failing tests to
avoid uploading huge zip files to bugs.webkit.org (with all the exected
IMAGE failures).

• Scripts/webkitpy/common/config/ports.py:
• Scripts/webkitpy/common/config/ports_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/config/ports.py (modified) (1 diff)
• Scripts/webkitpy/common/config/ports_unittest.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-12  Adam Barth  <abarth@webkit.org>
+
+        cr-linux-ews should run pixel tests
+        https://bugs.webkit.org/show_bug.cgi?id=64394
+
+        Reviewed by Ojan Vafai.
+
+        This patch enabled pixel test on the cr-linux-ews.  Running a quick
+        test on the bots, it looks like we have five pixel failures, related to
+        some missing fonts.  I've also made the bots skip failing tests to
+        avoid uploading huge zip files to bugs.webkit.org (with all the exected
+        IMAGE failures).
+
+        * Scripts/webkitpy/common/config/ports.py:
+        * Scripts/webkitpy/common/config/ports_unittest.py:
+
 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
 

trunk/Tools/Scripts/webkitpy/common/config/ports.py

@@ -246 +246 @@
         command = cls.script_shell_command("new-run-webkit-tests")
         command.append("--chromium")
-        command.append("--no-pixel-tests")
+        command.append("--skip-failing-tests")
         return command
 

trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py

@@ -65 +65 @@
         self.assertEquals(ChromiumPort.name(), "Chromium")
         self.assertEquals(ChromiumPort.flag(), "--port=chromium")
-        self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("new-run-webkit-tests"), "--chromium", "--no-pixel-tests"])
+        self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("new-run-webkit-tests"), "--chromium", "--skip-failing-tests"])
         self.assertEquals(ChromiumPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--chromium", "--update-chromium"])
         self.assertEquals(ChromiumPort.build_webkit_command(build_style="debug"), [WebKitPort.script_path("build-webkit"), "--debug", "--chromium", "--update-chromium"])
@@ -71 +71 @@
 
     def test_chromium_xvfb_port(self):
-        self.assertEquals(ChromiumXVFBPort.run_webkit_tests_command(), ['xvfb-run', 'Tools/Scripts/new-run-webkit-tests', '--chromium', '--no-pixel-tests', '--results-directory=/tmp/layout-test-results', '--skip-failing-tests', '--print=actual,config,expected,misc,slowest,unexpected,unexpected-results'])
+        self.assertEquals(ChromiumXVFBPort.run_webkit_tests_command(), ['xvfb-run', 'Tools/Scripts/new-run-webkit-tests', '--chromium', '--skip-failing-tests', '--results-directory=/tmp/layout-test-results', '--skip-failing-tests', '--print=actual,config,expected,misc,slowest,unexpected,unexpected-results'])
 
 if __name__ == '__main__':