Changeset 90880 in webkit


Ignore:
Timestamp:
Jul 12, 2011 7:39:16 PM (13 years ago)
Author:
abarth@webkit.org
Message:

garden-o-matic should label tests failures of new tests as such
​https://bugs.webkit.org/show_bug.cgi?id=64421

Reviewed by Ojan Vafai.

Also, we shouldn't dim failures of new tests, even if we've only seen
them once because they're likely to be real problems that need
attention.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
Location:
trunk/Tools
Files:
2 added
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r90879 r90880  
     12011-07-12  Adam Barth  <abarth@webkit.org>
     2
     3        garden-o-matic should label tests failures of new tests as such
     4        https://bugs.webkit.org/show_bug.cgi?id=64421
     5
     6        Reviewed by Ojan Vafai.
     7
     8        Also, we shouldn't dim failures of new tests, even if we've only seen
     9        them once because they're likely to be real problems that need
     10        attention.
     11
     12        * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
     13        * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
     14        * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
     15        * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
     16        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
     17        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
     18        * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
     19        * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
     20        * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
     21        * Scripts/webkitpy/tool/servers/gardeningserver.py:
     22
    1232011-07-12  Adam Barth  <abarth@webkit.org>
    224

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js

    r90866 r90880  
     1(function () {
     2
    13module("base");
    24
    … …  
    9395    });
    9496});
     97
     98})();

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html

    r90822 r90880  
    1616<script src="config.js"></script>
    1717<script src="base.js"></script>
     18<script src="checkout.js"></script>
    1819<script src="results.js"></script>
    1920<script src="ui.js"></script>

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css

    r90879 r90880  
    4242
    4343/* If we've only seen a given test failure once, we dim it so as not to distract the gardener. */
    44 .test[data-failure-count="1"] {
     44.test[data-failure-count="1"][data-new-test="false"] {
     45    -webkit-transition: 1s opacity;
    4546    opacity: 0.5;
    4647}
    … …  
    111112}
    112113
     114.regression .test[data-new-test="true"] .what a[draggable]::after {
     115    content: '(new)';
     116    margin: 0 3px;
     117}
     118
    113119.regression .what a {
    114120    padding: 1px 2px;
    115121    border-radius: 4px;
    116122    color: black;
    117     background-color: #f0f0f0;
    118123}
    119124

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js

    r90879 r90880  
    3131                results.unifyRegressionRanges(builderNameList, testName, function(oldestFailingRevision, newestPassingRevision) {
    3232                    $('.when', testSummary).append(ui.summarizeRegressionRange(oldestFailingRevision, newestPassingRevision));
     33                    checkout.existsAtRevision(checkout.subversionURLForTest(testName), newestPassingRevision, function(testExistedBeforeFailure) {
     34                        $(testSummary).attr('data-new-test', !testExistedBeforeFailure);
     35                    });
    3336                });
    3437                results.countFailureOccurances(builderNameList, testName, function(failureCount) {

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js

    r90879 r90880  
     1(function () {
     2
    13module("results");
    24
    … …  
    315317    ]);
    316318});
     319
     320})();

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html

    r90441 r90880  
    1414<script src="base.js"></script>
    1515<script src="base_unittests.js"></script>
     16<script src="checkout.js"></script>
     17<script src="checkout_unittests.js"></script>
    1618<script src="results.js"></script>
    1719<script src="results_unittests.js"></script>

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js

    r90879 r90880  
     1(function () {
     2
    13module("iu");
    24
    … …  
    6365        '<img src="http://example.com/layout-test-results/foo-bar-diff.png" class="diff">');
    6466});
     67
     68})();

  • trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py

    r90846 r90880  
    3838class GardeningHTTPRequestHandler(ReflectionHandler):
    3939    STATIC_FILE_NAMES = frozenset([
     40        "base.js",
     41        "checkout.js",
     42        "config.js",
     43        "favicon-green.png",
     44        "favicon-red.png",
    4045        "index.html",
    4146        "main.css",
     47        "main.js",
    4248        "partytime.gif",
    43         "base.js",
    44         "config.js",
    45         "main.js",
    4649        "results.js",
    4750        "ui.js",
    48         "favicon-green.png",
    49         "favicon-red.png",
    5051    ])
    5152
Note: See TracChangeset for help on using the changeset viewer.