Changeset 90926 in webkit


Ignore:
Timestamp:
Jul 13, 2011 10:02:57 AM (13 years ago)
Author:
abarth@webkit.org
Message:

Remove "Dismiss" button from garden-o-matic butterbar
​https://bugs.webkit.org/show_bug.cgi?id=64443

Reviewed by Dimitri Glazkov.

We don't have any persistent butter bar messages yet, so the dismiss
button is premature (and fairly heavy, visually).

  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r90924 r90926  
     12011-07-13  Adam Barth  <abarth@webkit.org>
     2
     3        Remove "Dismiss" button from garden-o-matic butterbar
     4        https://bugs.webkit.org/show_bug.cgi?id=64443
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        We don't have any persistent butter bar messages yet, so the dismiss
     9        button is premature (and fairly heavy, visually).
     10
     11        * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
     12        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
     13
    1142011-07-13  Adam Barth  <abarth@webkit.org>
    215

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html

    r90924 r90926  
    1111</head>
    1212<body>
    13 <div class="butterbar"><span class="status">Loading...</span> <a class="dismiss" href="#">Dismiss</a></div>
     13<div class="butterbar"><span class="status">Loading...</span></div>
    1414<div class="results"></div>
    1515<div class="results-detail">

  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js

    r90924 r90926  
    33function dismissButterbar()
    44{
    5     $('.butterbar').fadeOut();
     5    $('.butterbar').fadeOut('fast');
    66}
    77
    … …  
    6666        return;
    6767
    68     displayOnButterbar('Loading results');
     68    displayOnButterbar('Loading...');
    6969
    7070    results.fetchResultsURLs(builderName, testName, failureTypeList, function(resultsURLs) {
    … …  
    102102}
    103103
    104 $('.butterbar .dismiss').live('click', dismissButterbar);
    105104$('.regression .where li').live('mouseenter', showResultsDetail);
    106105$('.results-detail .dismiss').live('click', hideResultsDetail);
Note: See TracChangeset for help on using the changeset viewer.