Changeset 90935 in webkit


Ignore:
Timestamp:
Jul 13, 2011 11:49:16 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

[CSSRegions]content:-webkit-from-flow not applied correctly
https://bugs.webkit.org/show_bug.cgi?id=64438

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-13
Reviewed by Tony Chang.

Source/WebCore:

Forgot to modify getStringValue(), i was modifying only getStringValue(ExceptionCode&).

Test: fast/regions/content-webkit-from-flow-parsing.html (existing).

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::getStringValue):

LayoutTests:

Correct the layout test for content:-webkit-from-flow parsing. Testing getComputedStyle values for content property
was not done properly, as "flow-name" was passed instead of "-webkit-from-flow:'flow-name'".

  • fast/regions/content-webkit-from-flow-parsing-expected.txt:
  • fast/regions/script-tests/content-webkit-from-flow-parsing.js:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r90927 r90935  
     12011-07-13  Mihnea Ovidenie  <mihnea@adobe.com>
     2
     3        [CSSRegions]content:-webkit-from-flow not applied correctly
     4        https://bugs.webkit.org/show_bug.cgi?id=64438
     5
     6        Reviewed by Tony Chang.
     7
     8        Correct the layout test for content:-webkit-from-flow parsing. Testing getComputedStyle values for content property
     9        was not done properly, as "flow-name" was passed instead of "-webkit-from-flow:'flow-name'".
     10
     11        * fast/regions/content-webkit-from-flow-parsing-expected.txt:
     12        * fast/regions/script-tests/content-webkit-from-flow-parsing.js:
     13
    1142011-07-12  Philippe Normand  <pnormand@igalia.com>
    215
  • trunk/LayoutTests/fast/regions/content-webkit-from-flow-parsing-expected.txt

    r90642 r90935  
    1919PASS testCSSText("content: -webkit-from-flow(first flow)") is ""
    2020PASS testCSSText("content: -webkit-from-flow(first-flow)") is ""
    21 PASS testComputedStyle("'first-flow'") is "first-flow"
    22 PASS testComputedStyle("'first flow'") is "'first flow'"
    23 PASS testComputedStyle("'auto'") is "auto"
    24 PASS testComputedStyle("auto") is ""
    25 PASS testComputedStyle("initial") is ""
    26 PASS testComputedStyle("inherit") is ""
    27 PASS testComputedStyle("") is ""
    28 PASS testComputedStyle("1") is ""
    29 PASS testComputedStyle("1.2") is ""
    30 PASS testComputedStyle("-1") is ""
    31 PASS testComputedStyle("12px") is ""
    32 PASS testComputedStyle("''") is "''"
    33 PASS testComputedStyle("first flow") is ""
    34 PASS testComputedStyle("first-flow") is ""
     21PASS testComputedStyle("-webkit-from-flow('first-flow')") is "first-flow"
     22PASS testComputedStyle("-webkit-from-flow('first flow')") is "'first flow'"
     23PASS testComputedStyle("-webkit-from-flow('auto')") is "auto"
     24PASS testComputedStyle("-webkit-from-flow(auto)") is ""
     25PASS testComputedStyle("-webkit-from-flow(initial)") is ""
     26PASS testComputedStyle("-webkit-from-flow(inherit)") is ""
     27PASS testComputedStyle("-webkit-from-flow()") is ""
     28PASS testComputedStyle("-webkit-from-flow(1)") is ""
     29PASS testComputedStyle("-webkit-from-flow(1.2)") is ""
     30PASS testComputedStyle("-webkit-from-flow(-1)") is ""
     31PASS testComputedStyle("-webkit-from-flow(12px)") is ""
     32PASS testComputedStyle("-webkit-from-flow('')") is "''"
     33PASS testComputedStyle("-webkit-from-flow(first flow)") is ""
     34PASS testComputedStyle("-webkit-from-flow(first-flow)") is ""
    3535PASS successfullyParsed is true
    3636
  • trunk/LayoutTests/fast/regions/script-tests/content-webkit-from-flow-parsing.js

    r90642 r90935  
    3333shouldBeEqualToString('testCSSText("content: -webkit-from-flow(first-flow)")', "");
    3434
    35 shouldBeEqualToString('testComputedStyle("\'first-flow\'")', "first-flow");
    36 shouldBeEqualToString('testComputedStyle("\'first flow\'")', "'first flow'");
    37 shouldBeEqualToString('testComputedStyle("\'auto\'")', "auto");
    38 shouldBeEqualToString('testComputedStyle("auto")', "");
    39 shouldBeEqualToString('testComputedStyle("initial")', "");
    40 shouldBeEqualToString('testComputedStyle("inherit")', "");
    41 shouldBeEqualToString('testComputedStyle("")', "");
    42 shouldBeEqualToString('testComputedStyle("1")', "");
    43 shouldBeEqualToString('testComputedStyle("1.2")', "");
    44 shouldBeEqualToString('testComputedStyle("-1")', "");
    45 shouldBeEqualToString('testComputedStyle("12px")', "");
    46 shouldBeEqualToString('testComputedStyle("\'\'")', "''");
    47 shouldBeEqualToString('testComputedStyle("first flow")', "");
    48 shouldBeEqualToString('testComputedStyle("first-flow")', "");
     35shouldBeEqualToString('testComputedStyle("-webkit-from-flow(\'first-flow\')")', "first-flow");
     36shouldBeEqualToString('testComputedStyle("-webkit-from-flow(\'first flow\')")', "'first flow'");
     37shouldBeEqualToString('testComputedStyle("-webkit-from-flow(\'auto\')")', "auto");
     38shouldBeEqualToString('testComputedStyle("-webkit-from-flow(auto)")', "");
     39shouldBeEqualToString('testComputedStyle("-webkit-from-flow(initial)")', "");
     40shouldBeEqualToString('testComputedStyle("-webkit-from-flow(inherit)")', "");
     41shouldBeEqualToString('testComputedStyle("-webkit-from-flow()")', "");
     42shouldBeEqualToString('testComputedStyle("-webkit-from-flow(1)")', "");
     43shouldBeEqualToString('testComputedStyle("-webkit-from-flow(1.2)")', "");
     44shouldBeEqualToString('testComputedStyle("-webkit-from-flow(-1)")', "");
     45shouldBeEqualToString('testComputedStyle("-webkit-from-flow(12px)")', "");
     46shouldBeEqualToString('testComputedStyle("-webkit-from-flow(\'\')")', "''");
     47shouldBeEqualToString('testComputedStyle("-webkit-from-flow(first flow)")', "");
     48shouldBeEqualToString('testComputedStyle("-webkit-from-flow(first-flow)")', "");
    4949
    5050successfullyParsed = true;
  • trunk/Source/WebCore/ChangeLog

    r90933 r90935  
     12011-07-13  Mihnea Ovidenie  <mihnea@adobe.com>
     2
     3        [CSSRegions]content:-webkit-from-flow not applied correctly
     4        https://bugs.webkit.org/show_bug.cgi?id=64438
     5
     6        Reviewed by Tony Chang.
     7
     8        Forgot to modify getStringValue(), i was modifying only getStringValue(ExceptionCode&).
     9
     10        Test: fast/regions/content-webkit-from-flow-parsing.html (existing).
     11
     12        * css/CSSPrimitiveValue.cpp:
     13        (WebCore::CSSPrimitiveValue::getStringValue):
     14
    1152011-07-12  Ryosuke Niwa  <rniwa@webkit.org>
    216
  • trunk/Source/WebCore/css/CSSPrimitiveValue.cpp

    r90863 r90935  
    546546        case CSS_ATTR:
    547547        case CSS_URI:
     548#if ENABLE(CSS_REGIONS)
     549        case CSS_FROM_FLOW:
     550#endif
    548551             return m_value.string;
    549552        case CSS_IDENT:
Note: See TracChangeset for help on using the changeset viewer.