Changeset 90935 in webkit
- Timestamp:
- Jul 13, 2011 11:49:16 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r90927 r90935 1 2011-07-13 Mihnea Ovidenie <mihnea@adobe.com> 2 3 [CSSRegions]content:-webkit-from-flow not applied correctly 4 https://bugs.webkit.org/show_bug.cgi?id=64438 5 6 Reviewed by Tony Chang. 7 8 Correct the layout test for content:-webkit-from-flow parsing. Testing getComputedStyle values for content property 9 was not done properly, as "flow-name" was passed instead of "-webkit-from-flow:'flow-name'". 10 11 * fast/regions/content-webkit-from-flow-parsing-expected.txt: 12 * fast/regions/script-tests/content-webkit-from-flow-parsing.js: 13 1 14 2011-07-12 Philippe Normand <pnormand@igalia.com> 2 15 -
trunk/LayoutTests/fast/regions/content-webkit-from-flow-parsing-expected.txt
r90642 r90935 19 19 PASS testCSSText("content: -webkit-from-flow(first flow)") is "" 20 20 PASS testCSSText("content: -webkit-from-flow(first-flow)") is "" 21 PASS testComputedStyle(" 'first-flow'") is "first-flow"22 PASS testComputedStyle(" 'first flow'") is "'first flow'"23 PASS testComputedStyle(" 'auto'") is "auto"24 PASS testComputedStyle(" auto") is ""25 PASS testComputedStyle(" initial") is ""26 PASS testComputedStyle(" inherit") is ""27 PASS testComputedStyle(" ") is ""28 PASS testComputedStyle(" 1") is ""29 PASS testComputedStyle(" 1.2") is ""30 PASS testComputedStyle("- 1") is ""31 PASS testComputedStyle(" 12px") is ""32 PASS testComputedStyle(" ''") is "''"33 PASS testComputedStyle(" first flow") is ""34 PASS testComputedStyle(" first-flow") is ""21 PASS testComputedStyle("-webkit-from-flow('first-flow')") is "first-flow" 22 PASS testComputedStyle("-webkit-from-flow('first flow')") is "'first flow'" 23 PASS testComputedStyle("-webkit-from-flow('auto')") is "auto" 24 PASS testComputedStyle("-webkit-from-flow(auto)") is "" 25 PASS testComputedStyle("-webkit-from-flow(initial)") is "" 26 PASS testComputedStyle("-webkit-from-flow(inherit)") is "" 27 PASS testComputedStyle("-webkit-from-flow()") is "" 28 PASS testComputedStyle("-webkit-from-flow(1)") is "" 29 PASS testComputedStyle("-webkit-from-flow(1.2)") is "" 30 PASS testComputedStyle("-webkit-from-flow(-1)") is "" 31 PASS testComputedStyle("-webkit-from-flow(12px)") is "" 32 PASS testComputedStyle("-webkit-from-flow('')") is "''" 33 PASS testComputedStyle("-webkit-from-flow(first flow)") is "" 34 PASS testComputedStyle("-webkit-from-flow(first-flow)") is "" 35 35 PASS successfullyParsed is true 36 36 -
trunk/LayoutTests/fast/regions/script-tests/content-webkit-from-flow-parsing.js
r90642 r90935 33 33 shouldBeEqualToString('testCSSText("content: -webkit-from-flow(first-flow)")', ""); 34 34 35 shouldBeEqualToString('testComputedStyle(" \'first-flow\'")', "first-flow");36 shouldBeEqualToString('testComputedStyle(" \'first flow\'")', "'first flow'");37 shouldBeEqualToString('testComputedStyle(" \'auto\'")', "auto");38 shouldBeEqualToString('testComputedStyle(" auto")', "");39 shouldBeEqualToString('testComputedStyle(" initial")', "");40 shouldBeEqualToString('testComputedStyle(" inherit")', "");41 shouldBeEqualToString('testComputedStyle(" ")', "");42 shouldBeEqualToString('testComputedStyle(" 1")', "");43 shouldBeEqualToString('testComputedStyle(" 1.2")', "");44 shouldBeEqualToString('testComputedStyle("- 1")', "");45 shouldBeEqualToString('testComputedStyle(" 12px")', "");46 shouldBeEqualToString('testComputedStyle(" \'\'")', "''");47 shouldBeEqualToString('testComputedStyle(" first flow")', "");48 shouldBeEqualToString('testComputedStyle(" first-flow")', "");35 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(\'first-flow\')")', "first-flow"); 36 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(\'first flow\')")', "'first flow'"); 37 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(\'auto\')")', "auto"); 38 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(auto)")', ""); 39 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(initial)")', ""); 40 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(inherit)")', ""); 41 shouldBeEqualToString('testComputedStyle("-webkit-from-flow()")', ""); 42 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(1)")', ""); 43 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(1.2)")', ""); 44 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(-1)")', ""); 45 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(12px)")', ""); 46 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(\'\')")', "''"); 47 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(first flow)")', ""); 48 shouldBeEqualToString('testComputedStyle("-webkit-from-flow(first-flow)")', ""); 49 49 50 50 successfullyParsed = true; -
trunk/Source/WebCore/ChangeLog
r90933 r90935 1 2011-07-13 Mihnea Ovidenie <mihnea@adobe.com> 2 3 [CSSRegions]content:-webkit-from-flow not applied correctly 4 https://bugs.webkit.org/show_bug.cgi?id=64438 5 6 Reviewed by Tony Chang. 7 8 Forgot to modify getStringValue(), i was modifying only getStringValue(ExceptionCode&). 9 10 Test: fast/regions/content-webkit-from-flow-parsing.html (existing). 11 12 * css/CSSPrimitiveValue.cpp: 13 (WebCore::CSSPrimitiveValue::getStringValue): 14 1 15 2011-07-12 Ryosuke Niwa <rniwa@webkit.org> 2 16 -
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
r90863 r90935 546 546 case CSS_ATTR: 547 547 case CSS_URI: 548 #if ENABLE(CSS_REGIONS) 549 case CSS_FROM_FLOW: 550 #endif 548 551 return m_value.string; 549 552 case CSS_IDENT:
Note: See TracChangeset
for help on using the changeset viewer.