Changeset 90939 in webkit
- Timestamp:
- Jul 13, 2011 12:19:23 PM (13 years ago)
- Location:
- trunk/Source
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r90938 r90939 1 2011-07-13 David Levin <levin@chromium.org> 2 3 Possible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallRealDebugger. 4 https://bugs.webkit.org/show_bug.cgi?id=64465 5 6 Reviewed by Dmitry Titov. 7 8 There isn't a good way to test this as it is very highly unlikely to occur. 9 10 * wtf/ThreadIdentifierDataPthreads.cpp: 11 (WTF::ThreadIdentifierData::initializeKeyOnce): Since scoped static initialization 12 isn't thread-safe, change the initialization to be global. 13 1 14 2011-07-12 Gavin Barraclough <barraclough@apple.com> 2 15 -
trunk/Source/JavaScriptCore/wtf/ThreadIdentifierDataPthreads.cpp
r53714 r90939 1 1 /* 2 * Copyright (C) 2009 Google Inc. All rights reserved.2 * Copyright (C) 2009, 2011 Google Inc. All rights reserved. 3 3 * 4 4 * Redistribution and use in source and binary forms, with or without … … 40 40 41 41 pthread_key_t ThreadIdentifierData::m_key; 42 static pthread_once_t onceControl = PTHREAD_ONCE_INIT; 42 43 43 44 void clearPthreadHandleForIdentifier(ThreadIdentifier); … … 87 88 void ThreadIdentifierData::initializeKeyOnce() 88 89 { 89 static pthread_once_t onceControl = PTHREAD_ONCE_INIT;90 90 if (pthread_once(&onceControl, initializeKeyOnceHelper)) 91 91 CRASH(); -
trunk/Source/WebKit2/ChangeLog
r90909 r90939 1 2011-07-13 David Levin <levin@chromium.org> 2 3 Possible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallRealDebugger. 4 https://bugs.webkit.org/show_bug.cgi?id=64465 5 6 Reviewed by Dmitry Titov. 7 8 There isn't a good way to test this as it is very highly unlikely to occur. 9 10 * PluginProcess/mac/PluginProcessMac.mm: 11 (WebKit::shouldCallRealDebugger): :Since scoped static initialization 12 isn't thread-safe, change the initialization to be global. 13 1 14 2011-07-13 Andreas Kling <kling@webkit.org> 2 15 -
trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm
r84997 r90939 1 1 /* 2 2 * Copyright (C) 2010 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 4 * 4 5 * Redistribution and use in source and binary forms, with or without … … 40 41 namespace WebKit { 41 42 43 static pthread_once_t shouldCallRealDebuggerOnce = PTHREAD_ONCE_INIT; 44 42 45 class FullscreenWindowTracker { 43 46 WTF_MAKE_NONCOPYABLE(FullscreenWindowTracker); … … 133 136 static bool shouldCallRealDebugger() 134 137 { 135 static pthread_once_t shouldCallRealDebuggerOnce = PTHREAD_ONCE_INIT;136 138 pthread_once(&shouldCallRealDebuggerOnce, initShouldCallRealDebugger); 137 139
Note: See TracChangeset
for help on using the changeset viewer.