Changeset 90965 in webkit


Ignore:
Timestamp:
Jul 13, 2011 4:45:17 PM (13 years ago)
Author:
isherman@chromium.org
Message:

Fix WTF header guard style check
https://bugs.webkit.org/show_bug.cgi?id=64488

Reviewed by David Levin.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Verify that we don't *always* suggest "WTF_" as a prefix
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r90964 r90965  
     12011-07-13  Ilya Sherman  <isherman@chromium.org>
     2
     3        Fix WTF header guard style check
     4        https://bugs.webkit.org/show_bug.cgi?id=64488
     5
     6        Reviewed by David Levin.
     7
     8        * Scripts/webkitpy/style/checkers/cpp.py:
     9        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Verify that we don't *always* suggest "WTF_" as a prefix
     10
    1112011-07-13  Ojan Vafai  <ojan@chromium.org>
    212
  • trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py

    r89508 r90965  
    924924
    925925    # Files under WTF typically have header guards that start with WTF_.
    926     if filename.find('/wtf/'):
     926    if '/wtf/' in filename:
    927927        special_name = "WTF_" + standard_name
    928928    else:
  • trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

    r89508 r90965  
    22# -*- coding: utf-8; -*-
    33#
    4 # Copyright (C) 2009, 2010 Google Inc. All rights reserved.
     4# Copyright (C) 2011 Google Inc. All rights reserved.
    55# Copyright (C) 2009 Torch Mobile Inc.
    66# Copyright (C) 2009 Apple Inc. All rights reserved.
     
    21772177            error_collector.result_list())
    21782178
     2179        # Verify that we don't blindly suggest the WTF prefix for all headers.
     2180        self.assertFalse(expected_guard.startswith('WTF_'))
     2181
    21792182        # Allow the WTF_ prefix for files in that directory.
    21802183        header_guard_filter = FilterConfiguration(('-', '+build/header_guard'))
Note: See TracChangeset for help on using the changeset viewer.