Changeset 90970 in webkit


Ignore:
Timestamp:
Jul 13, 2011 7:05:02 PM (13 years ago)
Author:
simonjam@chromium.org
Message:

Remove hack that forcefully prevents scripts from running in shadow SVG
https://bugs.webkit.org/show_bug.cgi?id=64419

This hack was put in to prevent scripts from running in shadow SVG. This should never have
happened, but did because we didn't parse <script> tags in SVG properly. This was fixed in
r88584, so the hack is no longer needed.

No new tests since there is no change in functionality.

Reviewed by Tony Gentilcore.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r90966 r90970  
     12011-07-13  James Simonsen  <simonjam@chromium.org>
     2
     3        Remove hack that forcefully prevents scripts from running in shadow SVG
     4        https://bugs.webkit.org/show_bug.cgi?id=64419
     5
     6        This hack was put in to prevent scripts from running in shadow SVG. This should never have
     7        happened, but did because we didn't parse <script> tags in SVG properly. This was fixed in
     8        r88584, so the hack is no longer needed.
     9
     10        No new tests since there is no change in functionality.
     11
     12        Reviewed by Tony Gentilcore.
     13
     14        * dom/ScriptElement.cpp:
     15        (WebCore::ScriptElement::prepareScript):
     16
    1172011-07-13  Mihnea Ovidenie  <mihnea@adobe.com>
    218
  • trunk/Source/WebCore/dom/ScriptElement.cpp

    r88549 r90970  
    204204        return false;
    205205
    206     // FIXME: This is non-standard. Remove this after https://bugs.webkit.org/show_bug.cgi?id=62412.
    207     Node* ancestor = m_element->parentNode();
    208     while (ancestor) {
    209         if (ancestor->isSVGShadowRoot())
    210             return false;
    211         ancestor = ancestor->parentNode();
    212     }
    213 
    214206    if (!isScriptForEventSupported())
    215207        return false;
Note: See TracChangeset for help on using the changeset viewer.