Changeset 91009 in webkit
- Timestamp:
- Jul 14, 2011 10:24:13 AM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r91007 r91009 1 2011-07-14 Adam Barth <abarth@webkit.org> 2 3 garden-o-matic results pane should be more discoverable 4 https://bugs.webkit.org/show_bug.cgi?id=64513 5 6 Reviewed by Eric Seidel. 7 8 This patch causes us to trigger the results pane on mouse clicks 9 instead of mousein. Also, handle the case of no results details more 10 elegantly. 11 12 * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: 13 * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: 14 - Change the binding to "click". 15 * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: 16 - Handle the "no results URLs" case explicitly instead of never 17 calling the callback. 18 * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: 19 * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: 20 - Show a message when there are no result details to show. 21 * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: 22 1 23 2011-07-14 Adam Barth <abarth@webkit.org> 2 24 -
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css
r91007 r91009 147 147 border-radius: 4px; 148 148 color: #555; 149 }150 151 .regression .where li:hover {152 color: black;153 background-color: #f3f3f3;154 149 } 155 150 … … 198 193 } 199 194 195 .results-detail .failure-details .missing-data { 196 font-style: italic; 197 text-align: center; 198 } 199 200 200 .results-detail .failure-details { 201 201 height: 100%; -
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js
r90928 r91009 109 109 } 110 110 111 $('.regression .where li').live('mouseenter', showResultsDetail);111 $('.regression .where a').live('click', showResultsDetail); 112 112 $('.results-detail .dismiss').live('click', hideResultsDetail); 113 113 -
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js
r90924 r91009 430 430 var requestsInFlight = suffixList.length; 431 431 432 if (!requestsInFlight) { 433 callback([]); 434 return; 435 } 436 432 437 function checkComplete() 433 438 { -
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js
r90924 r91009 327 327 }); 328 328 329 test("fetchResultsURLs", 3, function() {329 test("fetchResultsURLs", 4, function() { 330 330 var simulator = new NetworkSimulator(); 331 331 … … 348 348 ]); 349 349 }); 350 results.fetchResultsURLs("Mock Builder", "userscripts/another-test.html", ['TIMEOUT'], function(resultURLs) { 351 deepEqual(resultURLs, []); 352 }); 350 353 }); 351 354 -
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js
r90924 r91009 43 43 var where = $('.where', block); 44 44 $.each(resultNodesByBuilder, function(builderName, resultNode) { 45 where.append($(' <li></li>').attr(config.kBuilderNameAttr, builderName).text(displayNameForBuilder(builderName)));45 where.append($('a', '<li><a href="#"></a></li>').attr(config.kBuilderNameAttr, builderName).text(displayNameForBuilder(builderName))); 46 46 }); 47 47 … … 78 78 { 79 79 var block = $('<table class="failure-details"><tbody><tr></tr></tbody></table>'); 80 81 if (!resultsURLs.length) 82 $('tr', block).append($('<td><div class="missing-data">No data</div></td>')); 83 80 84 $.each(resultsURLs, function(index, resultURL) { 81 85 var kind = results.resultKind(resultURL); … … 85 89 $('tr', block).append($('<td></td>').append(content)); 86 90 }); 91 87 92 return block; 88 93 }; -
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js
r90923 r91009 73 73 }); 74 74 75 test("failureDetails (empty)", 1, function() { 76 var testResults = ui.failureDetails([]); 77 testResults.wrap('<wrapper></wrapper>'); 78 equal(testResults.parent().html(), 79 '<table class="failure-details">' + 80 '<tbody>' + 81 '<tr>' + 82 '<td><div class="missing-data">No data</div></td>' + 83 '</tr>' + 84 '</tbody>' + 85 '</table>'); 86 }); 87 88 75 89 })();
Note: See TracChangeset
for help on using the changeset viewer.