Changeset 91009 in webkit


Ignore:
Timestamp:
Jul 14, 2011 10:24:13 AM (13 years ago)
Author:
abarth@webkit.org
Message:

garden-o-matic results pane should be more discoverable
https://bugs.webkit.org/show_bug.cgi?id=64513

Reviewed by Eric Seidel.

This patch causes us to trigger the results pane on mouse clicks
instead of mousein. Also, handle the case of no results details more
elegantly.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Change the binding to "click".
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Handle the "no results URLs" case explicitly instead of never calling the callback.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    • Show a message when there are no result details to show.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
Location:
trunk/Tools
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r91007 r91009  
     12011-07-14  Adam Barth  <abarth@webkit.org>
     2
     3        garden-o-matic results pane should be more discoverable
     4        https://bugs.webkit.org/show_bug.cgi?id=64513
     5
     6        Reviewed by Eric Seidel.
     7
     8        This patch causes us to trigger the results pane on mouse clicks
     9        instead of mousein.  Also, handle the case of no results details more
     10        elegantly.
     11
     12        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
     13        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
     14            - Change the binding to "click".
     15        * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
     16            - Handle the "no results URLs" case explicitly instead of never
     17              calling the callback.
     18        * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
     19        * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
     20            - Show a message when there are no result details to show.
     21        * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
     22
    1232011-07-14  Adam Barth  <abarth@webkit.org>
    224
  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css

    r91007 r91009  
    147147    border-radius: 4px;
    148148    color: #555;
    149 }
    150 
    151 .regression .where li:hover {
    152     color: black;
    153     background-color: #f3f3f3;
    154149}
    155150
     
    198193}
    199194
     195.results-detail .failure-details .missing-data {
     196    font-style: italic;
     197    text-align: center;
     198}
     199
    200200.results-detail .failure-details {
    201201    height: 100%;
  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js

    r90928 r91009  
    109109}
    110110
    111 $('.regression .where li').live('mouseenter', showResultsDetail);
     111$('.regression .where a').live('click', showResultsDetail);
    112112$('.results-detail .dismiss').live('click', hideResultsDetail);
    113113
  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js

    r90924 r91009  
    430430    var requestsInFlight = suffixList.length;
    431431
     432    if (!requestsInFlight) {
     433        callback([]);
     434        return;
     435    }
     436
    432437    function checkComplete()
    433438    {
  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js

    r90924 r91009  
    327327});
    328328
    329 test("fetchResultsURLs", 3, function() {
     329test("fetchResultsURLs", 4, function() {
    330330    var simulator = new NetworkSimulator();
    331331
     
    348348            ]);
    349349        });
     350        results.fetchResultsURLs("Mock Builder", "userscripts/another-test.html", ['TIMEOUT'], function(resultURLs) {
     351            deepEqual(resultURLs, []);
     352        });
    350353    });
    351354
  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js

    r90924 r91009  
    4343    var where = $('.where', block);
    4444    $.each(resultNodesByBuilder, function(builderName, resultNode) {
    45         where.append($('<li></li>').attr(config.kBuilderNameAttr, builderName).text(displayNameForBuilder(builderName)));
     45        where.append($('a', '<li><a href="#"></a></li>').attr(config.kBuilderNameAttr, builderName).text(displayNameForBuilder(builderName)));
    4646    });
    4747
     
    7878{
    7979    var block = $('<table class="failure-details"><tbody><tr></tr></tbody></table>');
     80
     81    if (!resultsURLs.length)
     82        $('tr', block).append($('<td><div class="missing-data">No data</div></td>'));
     83
    8084    $.each(resultsURLs, function(index, resultURL) {
    8185        var kind = results.resultKind(resultURL);
     
    8589        $('tr', block).append($('<td></td>').append(content));
    8690    });
     91
    8792    return block;
    8893};
  • trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js

    r90923 r91009  
    7373});
    7474
     75test("failureDetails (empty)", 1, function() {
     76    var testResults = ui.failureDetails([]);
     77    testResults.wrap('<wrapper></wrapper>');
     78    equal(testResults.parent().html(),
     79        '<table class="failure-details">' +
     80            '<tbody>' +
     81                '<tr>' +
     82                    '<td><div class="missing-data">No data</div></td>' +
     83                '</tr>' +
     84            '</tbody>' +
     85        '</table>');
     86});
     87
     88
    7589})();
Note: See TracChangeset for help on using the changeset viewer.