Changeset 91047 in webkit

Timestamp:

Jul 14, 2011 9:31:28 PM (13 years ago)

Author:

tkent@chromium.org

Message:

REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window loses focus
​https://bugs.webkit.org/show_bug.cgi?id=64537

Reviewed by Darin Adler.

Source/WebCore:

We stopped to call updateCheckedRadioButtons() for checkboxes
since r90809, but we need to call RenderTheme::stateChanged(),
which was in updateCheckedRadioButtons(), for checkboxes.

Tests: fast/forms/checkbox-appearance-change-by-checked-expected.html

fast/forms/checkbox-appearance-change-by-checked.html

• html/HTMLInputElement.cpp: Move the RenderTheme::stateChanged() call

from updateCheckedRadioButtons() to setChecked().
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::setChecked):

LayoutTests:

• fast/forms/checkbox-appearance-change-by-checked-expected.html: Added.
• fast/forms/checkbox-appearance-change-by-checked.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/checkbox-appearance-change-by-checked-expected.html (added)
• LayoutTests/fast/forms/checkbox-appearance-change-by-checked.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLInputElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-14  Kent Tamura  <tkent@chromium.org>
+
+        REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window loses focus
+        https://bugs.webkit.org/show_bug.cgi?id=64537
+
+        Reviewed by Darin Adler.
+
+        * fast/forms/checkbox-appearance-change-by-checked-expected.html: Added.
+        * fast/forms/checkbox-appearance-change-by-checked.html: Added.
+
 2011-07-14  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-14  Kent Tamura  <tkent@chromium.org>
+
+        REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window loses focus
+        https://bugs.webkit.org/show_bug.cgi?id=64537
+
+        Reviewed by Darin Adler.
+
+        We stopped to call updateCheckedRadioButtons() for checkboxes
+        since r90809, but we need to call RenderTheme::stateChanged(),
+        which was in updateCheckedRadioButtons(), for checkboxes.
+
+        Tests: fast/forms/checkbox-appearance-change-by-checked-expected.html
+               fast/forms/checkbox-appearance-change-by-checked.html
+
+        * html/HTMLInputElement.cpp: Move the RenderTheme::stateChanged() call
+        from updateCheckedRadioButtons() to setChecked().
+        (WebCore::HTMLInputElement::updateCheckedRadioButtons):
+        (WebCore::HTMLInputElement::setChecked):
+
 2011-07-14  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -210 +210 @@
         }
     }
-
-    if (renderer() && renderer()->style()->hasAppearance())
-        renderer()->theme()->stateChanged(renderer(), CheckedState);
 }
 
@@ -933 +930 @@
     m_isChecked = nowChecked;
     setNeedsStyleRecalc();
-    if (isRadioButton()) 
+    if (isRadioButton())
         updateCheckedRadioButtons();
+    if (renderer() && renderer()->style()->hasAppearance())
+        renderer()->theme()->stateChanged(renderer(), CheckedState);
     setNeedsValidityCheck();