Changeset 91049 in webkit

Timestamp:

Jul 14, 2011 10:37:26 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Replaced isChecked() with shouldAppearChecked() in HTMLInputElement.cpp along with all the corresponding function calls.
​https://bugs.webkit.org/show_bug.cgi?id=54476

Patch by SravanKumar S <​sravan.ken@gmail.com> on 2011-07-14
Reviewed by Darin Adler.

No new tests, since existing fast/dom/HTMLInputElement/checked-pseudo-selector.html verifies the patch.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isChecked):

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

• dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::removeButton):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::shouldAppearChecked):

• html/HTMLInputElement.h: Removed virtual declaration from shouldAppearChecked().
• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isChecked):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)
• css/CSSStyleSelector.cpp (modified) (2 diffs)
• dom/CheckedRadioButtons.cpp (modified) (1 diff)
• html/HTMLInputElement.cpp (modified) (1 diff)
• html/HTMLInputElement.h (modified) (1 diff)
• rendering/RenderTheme.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-14  SravanKumar S  <sravan.ken@gmail.com>
+
+        Replaced isChecked() with shouldAppearChecked() in HTMLInputElement.cpp along with all the corresponding function calls.
+        https://bugs.webkit.org/show_bug.cgi?id=54476
+
+        Reviewed by Darin Adler.
+
+        No new tests, since existing fast/dom/HTMLInputElement/checked-pseudo-selector.html verifies the patch.
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::isChecked):
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::canShareStyleWithControl):
+        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+        * dom/CheckedRadioButtons.cpp:
+        (WebCore::CheckedRadioButtons::removeButton):
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::shouldAppearChecked):
+        * html/HTMLInputElement.h: Removed virtual declaration from shouldAppearChecked().
+        * rendering/RenderTheme.cpp:
+        (WebCore::RenderTheme::isChecked):
+
 2011-07-14  Kenichi Ishibashi  <bashi@chromium.org>
 

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -620 +620 @@
     HTMLInputElement* inputElement = m_renderer->node()->toInputElement();
     if (inputElement)
-        return inputElement->isChecked();
+        return inputElement->shouldAppearChecked();
 
     // Else, if this is an ARIA checkbox or radio, respect the aria-checked attribute

trunk/Source/WebCore/css/CSSStyleSelector.cpp

@@ -1047 +1047 @@
     if (thisInputElement->isAutofilled() != otherInputElement->isAutofilled())
         return false;
-    if (thisInputElement->isChecked() != otherInputElement->isChecked())
+    if (thisInputElement->shouldAppearChecked() != otherInputElement->shouldAppearChecked())
         return false;
     if (thisInputElement->isIndeterminate() != otherInputElement->isIndeterminate())
@@ -2920 +2920 @@
                 // obey the CSS spec here in the test for matching the pseudo.
                 HTMLInputElement* inputElement = e->toInputElement();
-                if (inputElement && inputElement->isChecked() && !inputElement->isIndeterminate())
+                if (inputElement && inputElement->shouldAppearChecked() && !inputElement->isIndeterminate())
                     return true;
                 break;

trunk/Source/WebCore/dom/CheckedRadioButtons.cpp

@@ -80 +80 @@
     HTMLInputElement* inputElement = element->toInputElement();
     ASSERT_UNUSED(inputElement, inputElement);
-    ASSERT(inputElement->isChecked());
+    ASSERT(inputElement->shouldAppearChecked());
     ASSERT(element->isRadioButton());
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -1854 +1854 @@
 }
 
-bool HTMLInputElement::isChecked() const
+bool HTMLInputElement::shouldAppearChecked() const
 {
     return checked() && m_inputType->isCheckable();

trunk/Source/WebCore/html/HTMLInputElement.h

@@ -127 +127 @@
     bool indeterminate() const { return m_isIndeterminate; }
     void setIndeterminate(bool);
-
-    // isChecked is used by the rendering tree/CSS while checked() is used by JS to determine checked state
-    virtual bool isChecked() const;
+    // shouldAppearChecked is used by the rendering tree/CSS while checked() is used by JS to determine checked state
+    bool shouldAppearChecked() const;
     virtual bool isIndeterminate() const { return indeterminate(); }
 

trunk/Source/WebCore/rendering/RenderTheme.cpp

@@ -746 +746 @@
         return false;
 
-    return inputElement->isChecked();
+    return inputElement->shouldAppearChecked();
 }