Changeset 91053 in webkit


Ignore:
Timestamp:
Jul 14, 2011 11:33:24 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Remove LegacyDefaultOptionalArguments flag from WebGL
​https://bugs.webkit.org/show_bug.cgi?id=64549

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2011-07-14
Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/bad-arguments-test-expected.txt:
  • fast/canvas/webgl/bad-arguments-test.html:
  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost.html:
  • fast/canvas/webgl/null-object-behaviour-expected.txt:
  • fast/canvas/webgl/null-object-behaviour.html:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r91052 r91053  
     12011-07-14  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        Remove LegacyDefaultOptionalArguments flag from WebGL
     4        https://bugs.webkit.org/show_bug.cgi?id=64549
     5
     6        Reviewed by Kenneth Russell.
     7
     8        * fast/canvas/webgl/bad-arguments-test-expected.txt:
     9        * fast/canvas/webgl/bad-arguments-test.html:
     10        * fast/canvas/webgl/context-lost-expected.txt:
     11        * fast/canvas/webgl/context-lost.html:
     12        * fast/canvas/webgl/null-object-behaviour-expected.txt:
     13        * fast/canvas/webgl/null-object-behaviour.html:
     14
    1152011-07-14  Yuta Kitamura  <yutak@chromium.org>
    216

  • trunk/LayoutTests/fast/canvas/webgl/bad-arguments-test-expected.txt

    r65689 r91053  
    88PASS context.compileShader(argument) threw exception TypeError: Type error.
    99PASS context.linkProgram(argument) threw exception TypeError: Type error.
    10 PASS context.attachShader(argument) threw exception TypeError: Type error.
    1110PASS context.attachShader(program, argument) threw exception TypeError: Type error.
    1211PASS context.attachShader(argument, shader) threw exception TypeError: Type error.
    … …  
    3534PASS context.compileShader(argument) threw exception TypeError: Type error.
    3635PASS context.linkProgram(argument) threw exception TypeError: Type error.
    37 PASS context.attachShader(argument) threw exception TypeError: Type error.
    3836PASS context.attachShader(program, argument) threw exception TypeError: Type error.
    3937PASS context.attachShader(argument, shader) threw exception TypeError: Type error.
    … …  
    6260PASS context.compileShader(argument) is undefined.
    6361PASS context.linkProgram(argument) is undefined.
    64 PASS context.attachShader(argument) is undefined.
    6562PASS context.attachShader(program, argument) is undefined.
    6663PASS context.attachShader(argument, shader) is undefined.
    … …  
    8986PASS context.compileShader(argument) is undefined.
    9087PASS context.linkProgram(argument) is undefined.
    91 PASS context.attachShader(argument) is undefined.
    9288PASS context.attachShader(program, argument) is undefined.
    9389PASS context.attachShader(argument, shader) is undefined.

  • trunk/LayoutTests/fast/canvas/webgl/bad-arguments-test.html

    r65689 r91053  
    5656  func("context.compileShader(argument)");
    5757  func("context.linkProgram(argument)");
    58   func("context.attachShader(argument)");
    5958  func("context.attachShader(program, argument)");
    6059  func("context.attachShader(argument, shader)");

  • trunk/LayoutTests/fast/canvas/webgl/context-lost-expected.txt

    r75271 r91053  
    3535PASS gl.blendEquation(gl.FUNC_ADD) was expected value: NO_ERROR.
    3636PASS gl.blendEquationSeparate(gl.FUNC_ADD, gl.FUNC_ADD) was expected value: NO_ERROR.
    37 PASS gl.blendFunc(gl.ONE) was expected value: NO_ERROR.
    38 PASS gl.blendFuncSeparate(gl.ONE, gl.ONE) was expected value: NO_ERROR.
     37PASS gl.blendFunc(gl.ONE, gl.ONE) was expected value: NO_ERROR.
     38PASS gl.blendFuncSeparate(gl.ONE, gl.ONE, gl.ONE, gl.ONE) was expected value: NO_ERROR.
    3939PASS gl.bufferData(gl.ARRAY_BUFFER, 0, gl.STATIC_DRAW) was expected value: NO_ERROR.
    4040PASS gl.bufferData(gl.ARRAY_BUFFER, arrayBufferView, gl.STATIC_DRAW) was expected value: NO_ERROR.

  • trunk/LayoutTests/fast/canvas/webgl/context-lost.html

    r75271 r91053  
    133133        "gl.blendEquation(gl.FUNC_ADD)",
    134134        "gl.blendEquationSeparate(gl.FUNC_ADD, gl.FUNC_ADD)",
    135         "gl.blendFunc(gl.ONE)",
    136         "gl.blendFuncSeparate(gl.ONE, gl.ONE)",
     135        "gl.blendFunc(gl.ONE, gl.ONE)",
     136        "gl.blendFuncSeparate(gl.ONE, gl.ONE, gl.ONE, gl.ONE)",
    137137        "gl.bufferData(gl.ARRAY_BUFFER, 0, gl.STATIC_DRAW)",
    138138        "gl.bufferData(gl.ARRAY_BUFFER, arrayBufferView, gl.STATIC_DRAW)",

  • trunk/LayoutTests/fast/canvas/webgl/null-object-behaviour-expected.txt

    r65689 r91053  
    55PASS Program Compiled
    66PASS Shader Compiled
    7 PASS context.compileShader() was expected value: INVALID_VALUE.
    8 PASS context.linkProgram() was expected value: INVALID_VALUE.
    9 PASS context.attachShader() was expected value: INVALID_VALUE.
     7PASS context.compileShader(undefined) was expected value: INVALID_VALUE.
     8PASS context.linkProgram(undefined) was expected value: INVALID_VALUE.
     9PASS context.attachShader(undefined, undefined) was expected value: INVALID_VALUE.
    1010PASS context.attachShader(program, undefined) was expected value: INVALID_VALUE.
    1111PASS context.attachShader(undefined, shader) was expected value: INVALID_VALUE.
    1212PASS context.detachShader(program, undefined) was expected value: INVALID_VALUE.
    1313PASS context.detachShader(undefined, shader) was expected value: INVALID_VALUE.
    14 PASS context.shaderSource() was expected value: INVALID_VALUE.
     14PASS context.shaderSource(undefined, undefined) was expected value: INVALID_VALUE.
    1515PASS context.shaderSource(undefined, 'foo') was expected value: INVALID_VALUE.
    1616PASS context.bindAttribLocation(undefined, 0, 'foo') was expected value: INVALID_VALUE.

  • trunk/LayoutTests/fast/canvas/webgl/null-object-behaviour.html

    r65689 r91053  
    2121assertMsg(program != null, "Program Compiled");
    2222assertMsg(shader != null, "Shader Compiled");
    23 shouldGenerateGLError(context, context.INVALID_VALUE, "context.compileShader()");
    24 shouldGenerateGLError(context, context.INVALID_VALUE, "context.linkProgram()");
    25 shouldGenerateGLError(context, context.INVALID_VALUE, "context.attachShader()");
     23shouldGenerateGLError(context, context.INVALID_VALUE, "context.compileShader(undefined)");
     24shouldGenerateGLError(context, context.INVALID_VALUE, "context.linkProgram(undefined)");
     25shouldGenerateGLError(context, context.INVALID_VALUE, "context.attachShader(undefined, undefined)");
    2626shouldGenerateGLError(context, context.INVALID_VALUE, "context.attachShader(program, undefined)");
    2727shouldGenerateGLError(context, context.INVALID_VALUE, "context.attachShader(undefined, shader)");
    2828shouldGenerateGLError(context, context.INVALID_VALUE, "context.detachShader(program, undefined)");
    2929shouldGenerateGLError(context, context.INVALID_VALUE, "context.detachShader(undefined, shader)");
    30 shouldGenerateGLError(context, context.INVALID_VALUE, "context.shaderSource()");
     30shouldGenerateGLError(context, context.INVALID_VALUE, "context.shaderSource(undefined, undefined)");
    3131shouldGenerateGLError(context, context.INVALID_VALUE, "context.shaderSource(undefined, 'foo')");
    3232shouldGenerateGLError(context, context.INVALID_VALUE, "context.bindAttribLocation(undefined, 0, 'foo')");

  • trunk/Source/WebCore/ChangeLog

    r91052 r91053  
     12011-07-14  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        Remove LegacyDefaultOptionalArguments flag from WebGL
     4        https://bugs.webkit.org/show_bug.cgi?id=64549
     5
     6        Reviewed by Kenneth Russell.
     7
     8        * html/canvas/WebGLRenderingContext.idl:
     9
    1102011-07-14  Yuta Kitamura  <yutak@chromium.org>
    211

  • trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl

    r89393 r91053  
    2828    interface [
    2929        Conditional=WEBGL,
    30         LegacyDefaultOptionalArguments,
    3130        InterfaceUUID=98fb48ae-7216-489c-862b-8e1217fc4443,
    3231        ImplementationUUID=ab4f0781-152f-450e-9546-5b3987491a54,
Note: See TracChangeset for help on using the changeset viewer.