Changeset 91066 in webkit
- Timestamp:
- Jul 15, 2011 7:02:17 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r91061 r91066 1 2011-07-15 Jeff Miller <jeffm@apple.com> 2 3 Fullscreen content doesn't use fullscreen controller on Windows 4 https://bugs.webkit.org/show_bug.cgi?id=64540 5 <rdar://problem/9510455> 6 7 Reviewed by Darin Adler. 8 9 Add another test to video-controls-override.html to verify that 10 we're using the correct fullscreen controller by checking the 11 height of the controller panel, which is taller than the non-fullscreen 12 version. Unfortunately, the fullscreen tests don't work on Windows 13 yet, but I verified this would have caught this issue by simulating 14 the bug on the Mac. 15 16 * fullscreen/video-controls-override-expected.txt: Add new test to check the height of the panel. 17 18 * fullscreen/video-controls-override.html: Add new test to check the height of the panel, and 19 log errors if window.internals or window.layoutTestController are undefined. 20 1 21 2011-07-15 Mike West <mkwst@chromium.org> 2 22 -
trunk/LayoutTests/fullscreen/video-controls-override-expected.txt
r89682 r91066 6 6 EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK 7 7 EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK 8 EXPECTED (document.defaultView.getComputedStyle(panel)['height'] == '48px') OK 8 9 EVENT(webkitfullscreenchange) 9 10 EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK -
trunk/LayoutTests/fullscreen/video-controls-override.html
r89682 r91066 23 23 testExpected("internals.shadowPseudoId(panel)", "-webkit-media-controls-panel"); 24 24 testExpected("document.defaultView.getComputedStyle(panel)['display']", 'none', "!="); 25 testExpected("document.defaultView.getComputedStyle(panel)['height']", '48px'); 25 26 } 27 else 28 logResult(false, "window.internals == undefined"); 29 26 30 callback = cancelledFullScreen; 27 31 document.webkitCancelFullScreen(); … … 31 35 if (window.layoutTestController) 32 36 testExpected("document.defaultView.getComputedStyle(panel)['display']", 'none'); 37 else 38 logResult(false, "window.layoutTestController == undefined"); 39 33 40 endTest(); 34 41 }; -
trunk/Source/WebCore/ChangeLog
r91065 r91066 1 2011-07-15 Jeff Miller <jeffm@apple.com> 2 3 Fullscreen content doesn't use fullscreen controller on Windows 4 https://bugs.webkit.org/show_bug.cgi?id=64540 5 <rdar://problem/9510455> 6 7 Reviewed by Darin Adler. 8 9 RenderThemeWin needs to override extraFullScreenStyleSheet() to return 10 the fullscreenQuickTime stylesheet. 11 12 Test added to fullscreen/video-controls-override.html. 13 14 * rendering/RenderThemeWin.cpp: 15 (WebCore::RenderThemeWin::extraFullScreenStyleSheet): Added. 16 * rendering/RenderThemeWin.h: Override extraFullScreenStyleSheet(). 17 1 18 2011-07-15 Nikolas Zimmermann <nzimmermann@rim.com> 2 19 -
trunk/Source/WebCore/rendering/RenderThemeWin.cpp
r90075 r91066 1036 1036 } 1037 1037 1038 #if ENABLE(FULLSCREEN_API) 1039 String RenderThemeWin::extraFullScreenStyleSheet() 1040 { 1041 return String(fullscreenQuickTimeUserAgentStyleSheet, sizeof(fullscreenQuickTimeUserAgentStyleSheet)); 1042 } 1043 #endif 1044 1038 1045 bool RenderThemeWin::supportsClosedCaptioning() const 1039 1046 { -
trunk/Source/WebCore/rendering/RenderThemeWin.h
r88405 r91066 125 125 #if ENABLE(VIDEO) 126 126 virtual String extraMediaControlsStyleSheet(); 127 #if ENABLE(FULLSCREEN_API) 128 virtual String extraFullScreenStyleSheet(); 129 #endif 127 130 virtual bool supportsClosedCaptioning() const; 128 131 virtual bool paintMediaControlsBackground(RenderObject*, const PaintInfo&, const IntRect&);
Note: See TracChangeset
for help on using the changeset viewer.