Changeset 91239 in webkit

Timestamp:

Jul 18, 2011 10:33:10 PM (13 years ago)

Author:

aestes@apple.com

Message:

Solar Walk app-specific hack accidentally strips stylesheets from the document.
​https://bugs.webkit.org/show_bug.cgi?id=64777

Reviewed by Adam Barth.

Solar Walk uses a self-closed title tag in its documents ("<title />").
The HTML5 parser does not recognize this as a valid self-closing tag,
so it treats the remainder of the document as title text.

We work around this in WebKit by injecting a script that calls
document.write() on the contents of document.title, thereby restoring
the contents of the document. Unfortunately this overwrote several
<style> tags that existed before the <title>, thereby causing the
document to not have the intended styling.

Fix this by having the injected script concatenate document.title to
the document instead of overwriting it during document.write(). We can
also take the opportunity to remove document.title since it does not
contain useful information.

• Misc/SolarWalkQuirksUserScript.js:

Location:

trunk/Source/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• Misc/SolarWalkQuirksUserScript.js (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2011-07-18  Andy Estes  <aestes@apple.com>
+
+        Solar Walk app-specific hack accidentally strips stylesheets from the document.
+        https://bugs.webkit.org/show_bug.cgi?id=64777
+
+        Reviewed by Adam Barth.
+        
+        Solar Walk uses a self-closed title tag in its documents ("<title />").
+        The HTML5 parser does not recognize this as a valid self-closing tag,
+        so it treats the remainder of the document as title text.
+        
+        We work around this in WebKit by injecting a script that calls
+        document.write() on the contents of document.title, thereby restoring
+        the contents of the document. Unfortunately this overwrote several
+        <style> tags that existed before the <title>, thereby causing the
+        document to not have the intended styling.
+        
+        Fix this by having the injected script concatenate document.title to
+        the document instead of overwriting it during document.write(). We can
+        also take the opportunity to remove document.title since it does not
+        contain useful information.
+
+        * Misc/SolarWalkQuirksUserScript.js:
+
 2011-07-18  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebKit/mac/Misc/SolarWalkQuirksUserScript.js

@@ -29 +29 @@
         // Solar Walk uses a self closing title tag, so to match the behavior of the old parser, 
         // we write the contents of the title element to the end of the document so it can be re-parsed.
-        document.write(document.title);
+        document.write(document.documentElement.outerHTML + document.title);
+        
+        // Remove <title> since SolarWalk intended it to be empty.
+        document.head.removeChild(document.title);
     }