Changeset 91244 in webkit

Timestamp:

Jul 19, 2011 2:21:01 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Patch by Robin Qiu <​robin.qiu@torchmobile.com.cn> on 2011-07-19
Reviewed by Antonio Gomes.

ScrollBar should initialize current position in constructor.
​https://bugs.webkit.org/show_bug.cgi?id=39284

When ScrollBar is created, m_currentPos should be initialized to
m_scrollableArea's current scrollPosition. Because scrollbars may
be created after the content of m_scrollableArea has been scrolled.

Source/WebCore:

Test: scrollbars/scrollbar-initial-position.html

• platform/Scrollbar.cpp:

(WebCore::Scrollbar::Scrollbar):

LayoutTests:

• scrollbars/scrollbar-initial-position-expected.png: Added.
• scrollbars/scrollbar-initial-position-expected.txt: Added.
• scrollbars/scrollbar-initial-position.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/scrollbars/scrollbar-initial-position-expected.png (added)
• LayoutTests/scrollbars/scrollbar-initial-position-expected.txt (added)
• LayoutTests/scrollbars/scrollbar-initial-position.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/Scrollbar.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-19  Robin Qiu  <robin.qiu@torchmobile.com.cn>
+
+        Reviewed by Antonio Gomes.
+
+        ScrollBar should initialize current position in constructor.
+        https://bugs.webkit.org/show_bug.cgi?id=39284
+
+        When ScrollBar is created, m_currentPos should be initialized to
+        m_scrollableArea's current scrollPosition. Because scrollbars may
+        be created after the content of m_scrollableArea has been scrolled.
+
+        * scrollbars/scrollbar-initial-position-expected.png: Added.
+        * scrollbars/scrollbar-initial-position-expected.txt: Added.
+        * scrollbars/scrollbar-initial-position.html: Added.
+
 2011-07-19  Yuta Kitamura  <yutak@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-19  Robin Qiu  <robin.qiu@torchmobile.com.cn>
+
+        Reviewed by Antonio Gomes.
+
+        ScrollBar should initialize current position in constructor.
+        https://bugs.webkit.org/show_bug.cgi?id=39284
+
+        When ScrollBar is created, m_currentPos should be initialized to
+        m_scrollableArea's current scrollPosition. Because scrollbars may
+        be created after the content of m_scrollableArea has been scrolled.
+
+        Test: scrollbars/scrollbar-initial-position.html
+
+        * platform/Scrollbar.cpp:
+        (WebCore::Scrollbar::Scrollbar):
+
 2011-07-19  Yuta Kitamura  <yutak@chromium.org>
 

trunk/Source/WebCore/platform/Scrollbar.cpp

@@ -98 +98 @@
     int thickness = m_theme->scrollbarThickness(controlSize);
     Widget::setFrameRect(IntRect(0, 0, thickness, thickness));
+
+    if (m_scrollableArea)
+        m_currentPos = static_cast<float>(m_scrollableArea->scrollPosition(this));
 }