Changeset 91261 in webkit


Ignore:
Timestamp:
Jul 19, 2011 9:13:33 AM (13 years ago)
Author:
weinig@apple.com
Message:

webkit-patch rebaseline crashes on use
https://bugs.webkit.org/show_bug.cgi?id=64775

Reviewed by Adam Roben.

Fix incorrectly spelled attribute name.

  • Scripts/webkitpy/common/net/layouttestresults.py:

The attribute is test_name, not filename.

  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:

Add test for tests_matching_failure_types.

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r91245 r91261  
     12011-07-19  Sam Weinig  <sam@webkit.org>
     2
     3        webkit-patch rebaseline crashes on use
     4        https://bugs.webkit.org/show_bug.cgi?id=64775
     5
     6        Reviewed by Adam Roben.
     7
     8        Fix incorrectly spelled attribute name.
     9
     10        * Scripts/webkitpy/common/net/layouttestresults.py:
     11        The attribute is test_name, not filename.
     12
     13        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
     14        Add test for tests_matching_failure_types.
     15
    1162011-07-18  Eric Seidel  <eric@webkit.org>
    217
  • trunk/Tools/Scripts/webkitpy/common/net/layouttestresults.py

    r90532 r91261  
    165165
    166166    def tests_matching_failure_types(self, failure_types):
    167         return [result.filename for result in self.results_matching_failure_types(failure_types)]
     167        return [result.test_name for result in self.results_matching_failure_types(failure_types)]
    168168
    169169    def failing_test_results(self):
  • trunk/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

    r90532 r91261  
    6262"""
    6363
     64    _example_results_html_with_failing_tests = """
     65<html>
     66<head>
     67<title>Layout Test Results</title>
     68</head>
     69<body>
     70<p>Tests where results did not match expected results:</p>
     71<table>
     72<tr>
     73<td><a href="http://trac.webkit.org/export/91245/trunk/LayoutTests/compositing/plugins/composited-plugin.html">compositing/plugins/composited-plugin.html</a></td>
     74<td>
     75<a href="compositing/plugins/composited-plugin-expected.txt">expected</a>
     76</td>
     77<td>
     78<a href="compositing/plugins/composited-plugin-actual.txt">actual</a>
     79</td>
     80<td>
     81<a href="compositing/plugins/composited-plugin-diffs.txt">diff</a>
     82</td>
     83<td>
     84<a href="compositing/plugins/composited-plugin-pretty-diff.html">pretty diff</a>
     85</td>
     86</tr>
     87</table>
     88<p>Tests that had stderr output:</p>
     89<table>
     90<tr>
     91<td><a href="/var/lib/buildbot/build/gtk-linux-64-release/build/LayoutTests/accessibility/aria-activedescendant-crash.html">accessibility/aria-activedescendant-crash.html</a></td>
     92<td><a href="accessibility/aria-activedescendant-crash-stderr.txt">stderr</a></td>
     93</tr>
     94<td><a href="/var/lib/buildbot/build/gtk-linux-64-release/build/LayoutTests/http/tests/security/canvas-remote-read-svg-image.html">http/tests/security/canvas-remote-read-svg-image.html</a></td>
     95<td><a href="http/tests/security/canvas-remote-read-svg-image-stderr.txt">stderr</a></td>
     96</tr>
     97</table><p>Tests that had no expected results (probably new):</p>
     98<table>
     99<tr>
     100<td><a href="/var/lib/buildbot/build/gtk-linux-64-release/build/LayoutTests/fast/repaint/no-caret-repaint-in-non-content-editable-element.html">fast/repaint/no-caret-repaint-in-non-content-editable-element.html</a></td>
     101<td><a href="fast/repaint/no-caret-repaint-in-non-content-editable-element-actual.txt">result</a></td>
     102</tr>
     103</table></body>
     104</html>
     105"""
     106
    64107    def test_parse_layout_test_results(self):
    65108        failures = [test_failures.FailureMissingResult(), test_failures.FailureMissingImageHash(), test_failures.FailureMissingImage()]
     
    97140        results = LayoutTestResults.results_from_string(ORWTResultsHTMLParserTest._example_results_html)
    98141        self.assertEqual(len(results.failing_tests()), 0)
     142
     143    def test_tests_matching_failure_types(self):
     144        results = LayoutTestResults.results_from_string(ORWTResultsHTMLParserTest._example_results_html_with_failing_tests)
     145        failing_tests = results.tests_matching_failure_types([test_failures.FailureTextMismatch])
     146        self.assertEqual(len(results.failing_tests()), 1)
Note: See TracChangeset for help on using the changeset viewer.