Changeset 91269 in webkit

Timestamp:

Jul 19, 2011 10:26:12 AM (13 years ago)

Author:

rwlbuis@webkit.org

Message:

2011-07-19 Rob Buis <​rbuis@rim.com>

​https://bugs.webkit.org/show_bug.cgi?id=64673
REGRESSION (Safari 5.0.5 - ToT): crash in SVG test ​http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/styling-pres-02-f.html

Reviewed by Nikolas Zimmermann.

Prevent calling back to the owning SVGTRefElement upon handling DOMSubtreeModified events.

Test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg

• svg/SVGTRefElement.cpp: (WebCore::SubtreeModificationEventListener::handleEvent):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGTRefElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-19  Rob Buis  <rbuis@rim.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=64673
+        REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/styling-pres-02-f.html
+
+        Reviewed by Nikolas Zimmermann.
+
+        * platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
+        * svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg: Added.
+
 2011-07-19  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-19  Rob Buis  <rbuis@rim.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=64673
+        REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/styling-pres-02-f.html
+
+        Reviewed by Nikolas Zimmermann.
+
+        Prevent calling back to the owning SVGTRefElement upon handling DOMSubtreeModified events.
+
+        Test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg
+
+        * svg/SVGTRefElement.cpp:
+        (WebCore::SubtreeModificationEventListener::handleEvent):
+
 2011-07-19  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/svg/SVGTRefElement.cpp

@@ -102 +102 @@
 void SubtreeModificationEventListener::handleEvent(ScriptExecutionContext*, Event* event)
 {
-    if (event->type() == eventNames().DOMSubtreeModifiedEvent)
+    if (event->type() == eventNames().DOMSubtreeModifiedEvent && m_trefElement != event->target())
         m_trefElement->updateReferencedText();
 }