Changeset 91333 in webkit
- Timestamp:
- Jul 19, 2011 9:46:35 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r91332 r91333 1 2011-07-19 Kent Tamura <tkent@chromium.org> 2 3 REGRESSION(r89004): Video pauses and never resumes playing if scrubbed during playback. 4 https://bugs.webkit.org/show_bug.cgi?id=64314 5 6 Reviewed by Sam Weinig. 7 8 No new tests because it's hard to make a non-flaky test for this behavior. 9 10 * html/RangeInputType.cpp: 11 (WebCore::RangeInputType::handleMouseDownEvent): 12 Don't call SliderThumbElement::dragFrom() for events on the thumb. 13 * html/shadow/SliderThumbElement.cpp: 14 (WebCore::SliderThumbElement::defaultEventHandler): 15 Do not call setDefaultHandled() for mouse events in order to 16 propagate them to ancestor elements. 17 1 18 2011-07-19 Matthew Delaney <mdelaney@apple.com> 2 19 -
trunk/Source/WebCore/html/RangeInputType.cpp
r90737 r91333 157 157 if (event->button() != LeftButton || !targetNode || (targetNode != element() && !targetNode->isDescendantOf(element()->shadowRoot()))) 158 158 return; 159 160 159 SliderThumbElement* thumb = sliderThumbElementOf(element()); 160 if (targetNode == thumb) 161 return; 161 162 thumb->dragFrom(event->absoluteLocation()); 162 event->setDefaultHandled();163 163 } 164 164 -
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp
r89521 r91333 280 280 const AtomicString& eventType = event->type(); 281 281 282 // We intentionally do not call event->setDefaultHandled() here because 283 // MediaControlTimelineElement::defaultEventHandler() wants to handle these 284 // mouse events. 282 285 if (eventType == eventNames().mousedownEvent && isLeftButton) { 283 286 startDragging(); 284 event->setDefaultHandled();285 287 return; 286 288 } else if (eventType == eventNames().mouseupEvent && isLeftButton) { 287 289 stopDragging(); 288 event->setDefaultHandled();289 290 return; 290 291 } else if (eventType == eventNames().mousemoveEvent) { 291 292 if (m_inDragMode) 292 293 setPositionFromPoint(mouseEvent->absoluteLocation()); 293 event->setDefaultHandled();294 294 return; 295 295 }
Note: See TracChangeset
for help on using the changeset viewer.