Changeset 91416 in webkit

Timestamp:

Jul 20, 2011 4:15:31 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebCore: mouseover reporting incorrect mouse button, when the button isn't
down. ​https://bugs.webkit.org/show_bug.cgi?id=64882

Patch by Scott Graham <​scottmg@chromium.org> on 2011-07-20
Reviewed by Eric Seidel.

Don't increment the button returned in 'which' unless the button is
actually down.

Test: fast/events/mouseover-button.html

• dom/MouseEvent.cpp:

(WebCore::MouseEvent::which):

LayoutTests: mouseover event reporting incorrect button in 'which'.
​https://bugs.webkit.org/show_bug.cgi?id=64882

New test, move in/out of iframe with none/left/middle buttons down.

Patch by Scott Graham <​scottmg@chromium.org> on 2011-07-20
Reviewed by Eric Seidel.

• fast/events/mouseover-button-expected.txt: Added.
• fast/events/mouseover-button.html: Added.
• fast/events/resources/mouseover-button-iframe.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/mouseover-button-expected.txt (added)
• LayoutTests/fast/events/mouseover-button.html (added)
• LayoutTests/fast/events/resources/mouseover-button-iframe.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/MouseEvent.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-20  Scott Graham  <scottmg@chromium.org>
+
+        mouseover event reporting incorrect button in 'which'.
+        https://bugs.webkit.org/show_bug.cgi?id=64882
+
+        New test, move in/out of iframe with none/left/middle buttons down.
+
+        Reviewed by Eric Seidel.
+
+        * fast/events/mouseover-button-expected.txt: Added.
+        * fast/events/mouseover-button.html: Added.
+        * fast/events/resources/mouseover-button-iframe.html: Added.
+
 2011-07-20  Kenneth Russell  <kbr@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-20  Scott Graham  <scottmg@chromium.org>
+
+        mouseover reporting incorrect mouse button, when the button isn't
+        down. https://bugs.webkit.org/show_bug.cgi?id=64882
+
+        Reviewed by Eric Seidel.
+
+        Don't increment the button returned in 'which' unless the button is
+        actually down.
+
+        Test: fast/events/mouseover-button.html
+
+        * dom/MouseEvent.cpp:
+        (WebCore::MouseEvent::which):
+
 2011-07-20  Kenneth Russell  <kbr@google.com>
 

trunk/Source/WebCore/dom/MouseEvent.cpp

@@ -110 +110 @@
     // For the Netscape "which" property, the return values for left, middle and right mouse buttons are 1, 2, 3, respectively. 
     // So we must add 1.
+    if (!m_buttonDown)
+        return 0;
     return m_button + 1;
 }