Changeset 91487 in webkit

Timestamp:

Jul 21, 2011 12:14:39 PM (13 years ago)

Author:

abarth@webkit.org

Message:

garden-o-matic should be able to rebaseline many tests at once
​https://bugs.webkit.org/show_bug.cgi?id=64963

Reviewed by Dimitri Glazkov.

This patch contains some UI for rebaselining tests in bulk. I don't
expect this UI to be the final UI, but the underlying infrastructure
will be useful.

• Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
• Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
• Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
• Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
• Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js (modified) (2 diffs)
• Scripts/webkitpy/tool/servers/data/gardeningserver/index.html (modified) (1 diff)
• Scripts/webkitpy/tool/servers/data/gardeningserver/main.js (modified) (2 diffs)
• Scripts/webkitpy/tool/servers/data/gardeningserver/results.js (modified) (4 diffs)
• Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-21  Adam Barth  <abarth@webkit.org>
+
+        garden-o-matic should be able to rebaseline many tests at once
+        https://bugs.webkit.org/show_bug.cgi?id=64963
+
+        Reviewed by Dimitri Glazkov.
+
+        This patch contains some UI for rebaselining tests in bulk.  I don't
+        expect this UI to be the final UI, but the underlying infrastructure
+        will be useful.
+
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
+
 2011-07-21  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js

@@ -37 +37 @@
     });
 
-    var requestsInFlight = extensionList.length;
+    if (!extensionList.length)
+        callback();
 
-    if (!requestsInFlight)
-        callback();
+    var requestTracker = new base.RequestTracker(extensionList.length, callback);
 
     $.each(extensionList, function(index, extension) {
@@ -49 +49 @@
             'suffix': extension
         }), function() {
-            --requestsInFlight;
-            if (!requestsInFlight)
-                callback();
+            requestTracker.requestComplete();
         });
     });
 };
 
+checkout.rebaselineAll = function(rebaselineTasks, callback)
+{
+    var nextIndex = 0;
+
+    function rebaselineNext()
+    {
+        if (nextIndex >= rebaselineTasks.length) {
+            callback();
+            return;
+        }
+        var task = rebaselineTasks[nextIndex++];
+        checkout.rebaseline(task.builderName, task.testName, task.failureTypeList, rebaselineNext);
+    }
+
+    rebaselineNext();
+};
+
 })();

trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html

@@ -18 +18 @@
         <div class="actions">
             <button class="triage">Triage Failures</button>
+            <button class="rebaseline-selected">Rebaseline Selected</button>
         </div>
     </div>

trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js

@@ -247 +247 @@
 }
 
+function rebaselineSelected()
+{
+    var rebaselineTasks = [];
+
+    $('.results .test input:checkbox').each(function() {
+        if (!this.checked)
+            return;
+        var testSummary = $(this).parents('.test');
+        var testName = testSummary.attr(config.kTestNameAttr);
+        $('.builder-name', testSummary).each(function() {
+            var builderName = $(this).attr(config.kBuilderNameAttr);
+            var failureTypes = $(this).attr(config.kFailureTypesAttr);
+            var failureTypeList = failureTypes.split(' ');
+            rebaselineTasks.push({
+                'builderName': builderName,
+                'testName': testName,
+                'failureTypeList': failureTypeList,
+            });
+        });
+    });
+
+    displayOnButterbar('Rebaselining...');
+    checkout.rebaselineAll(rebaselineTasks, dismissButterbar);
+}
+
 function rebaselineResults()
 {
@@ -279 +304 @@
 
 $('.results .toolbar .triage').live('click', triageFailures);
+$('.results .toolbar .rebaseline-selected').live('click', rebaselineSelected);
 $('.results-detail .actions .next').live('click', nextResultsDetail);
 $('.results-detail .actions .previous').live('click', previousResultsDetail);

trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js

@@ -204 +204 @@
 }
 
-function unexpectedResults(resultNode)
+results.unexpectedResults = function(resultNode)
 {
     var actualResults = resultNode.actual.split(' ');
@@ -212 +212 @@
         return expectedResults.indexOf(result) == -1;
     });
-}
+};
 
 function isUnexpectedFailure(resultNode)
@@ -220 +220 @@
     if (anyIsSuccess(resultNode.actual.split(' ')))
         return false;
-    return anyIsFailure(unexpectedResults(resultNode));
+    return anyIsFailure(results.unexpectedResults(resultNode));
 }
 
@@ -254 +254 @@
 results.collectUnexpectedResults = function(dictionaryOfResultNodes)
 {
-    var collectedResults = {};
-    var results = [];
+    var collectedResults = [];
     $.each(dictionaryOfResultNodes, function(key, resultNode) {
-        results = results.concat(unexpectedResults(resultNode));
-    });
-    return base.uniquifyArray(results);
+        collectedResults = collectedResults.concat(results.unexpectedResults(resultNode));
+    });
+    return base.uniquifyArray(collectedResults);
 };
 

trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js

@@ -49 +49 @@
     var block = $(
         '<tr class="test">' +
+          '<td><input type="checkbox"></td>' +
           '<td class="what"><a class="test-name"></a></td>' +
           '<td class="where"><ul></ul></td>' +
@@ -62 +63 @@
     $.each(resultNodesByBuilder, function(builderName, resultNode) {
         var listElement = $('<li class="builder-name"></li>');
-        listElement.attr(config.kBuilderNameAttr, builderName).text(displayNameForBuilder(builderName));
+        listElement.attr(config.kBuilderNameAttr, builderName).attr(config.kFailureTypesAttr, results.unexpectedResults(resultNode)).text(displayNameForBuilder(builderName));
         where.append(listElement);
     });