Changeset 91741 in webkit

Timestamp:

Jul 25, 2011 10:11:47 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Remove unused code in ewk_tile_model.c
​https://bugs.webkit.org/show_bug.cgi?id=64521

Remove unused code in ewk_tile_model.c. Dirty flag is not referenced anywhere.

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2011-07-25
Reviewed by Daniel Bates.

• ewk/ewk_tiled_model.c:

(ewk_tile_unused_cache_clear):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_tiled_model.c (modified) (6 diffs)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-07-25  JungJik Lee  <jungjik.lee@samsung.com>
+
+        [EFL] Remove unused code in ewk_tile_model.c
+        https://bugs.webkit.org/show_bug.cgi?id=64521
+
+        Remove unused code in ewk_tile_model.c. Dirty flag is not referenced anywhere.
+
+        Reviewed by Daniel Bates.
+
+        * ewk/ewk_tiled_model.c:
+        (ewk_tile_unused_cache_clear):
+        (ewk_tile_unused_cache_flush):
+        (ewk_tile_unused_cache_tile_get):
+        (ewk_tile_unused_cache_tile_put):
+
 2011-07-25  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_tiled_model.c

@@ -517 +517 @@
     int references;
     unsigned int frozen;
-    Eina_Bool dirty:1;
 };
 
@@ -613 +612 @@
     tuc->memory.used = 0;
     tuc->entries.count = 0;
-    tuc->dirty = EINA_FALSE;
 }
 
@@ -707 +705 @@
      * Don't need to sort any more.
      */
-
-    if (tuc->dirty)
-        tuc->dirty = EINA_FALSE;
 
     done = 0;
@@ -761 +756 @@
 
 /**
- * Flag cache as dirty.
- *
- * If cache is dirty then next flush operations will have to recompute
- * weight and sort again to find the best tiles to expire.
- *
- * One must call this function when tile properties that may change
- * likeness of tile to be flushed change, like Tile::stats.
- */
-void ewk_tile_unused_cache_dirty(Ewk_Tile_Unused_Cache *tuc)
-{
-    tuc->dirty = EINA_TRUE;
-}
-
-/**
  * Freeze cache to not do maintenance tasks.
  *
@@ -838 +819 @@
     tuc->entries.list = eina_list_remove_list(tuc->entries.list, e);
     free(entry);
-    // TODO assume dirty for now, but may it's not,
-    // if the item was at the beginning of the queue
-    tuc->dirty = EINA_TRUE;
 
     return EINA_TRUE;
@@ -890 +868 @@
     tuc->entries.count++;
     tuc->memory.used += sizeof(Ewk_Tile) + t->bytes;
-    tuc->dirty = EINA_TRUE;
 
     return EINA_TRUE;