Changeset 91879 in webkit

Timestamp:

Jul 27, 2011 4:16:25 PM (13 years ago)

Author:

leviw@chromium.org

Message:

unicode-bidi:-webkit-plaintext does not work on <textarea>
​https://bugs.webkit.org/show_bug.cgi?id=65074

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixing unicode-bidi style propagation into text control shadow trees.

Test: fast/text/international/unicode-bidi-plaintext-in-textarea.html

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle):

LayoutTests:

Fixing unicode-bidi propagation into text controls.

• fast/text/international/unicode-bidi-plaintext-in-textarea.html: Added.
• platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
• platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text/international/unicode-bidi-plaintext-in-textarea.html (added)
• LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png (added)
• LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTextControl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-27  Levi Weintraub  <leviw@chromium.org>
+
+        unicode-bidi:-webkit-plaintext does not work on <textarea>
+        https://bugs.webkit.org/show_bug.cgi?id=65074
+
+        Reviewed by Ryosuke Niwa.
+
+        Fixing unicode-bidi propagation into text controls.
+
+        * fast/text/international/unicode-bidi-plaintext-in-textarea.html: Added.
+        * platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
+        * platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
+
 2011-07-27  Adrienne Walker  <enne@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-27  Levi Weintraub  <leviw@chromium.org>
+
+        unicode-bidi:-webkit-plaintext does not work on <textarea>
+        https://bugs.webkit.org/show_bug.cgi?id=65074
+
+        Reviewed by Ryosuke Niwa.
+
+        Fixing unicode-bidi style propagation into text control shadow trees.
+
+        Test: fast/text/international/unicode-bidi-plaintext-in-textarea.html
+
+        * rendering/RenderTextControl.cpp:
+        (WebCore::RenderTextControl::adjustInnerTextStyle):
+
 2011-07-27  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/rendering/RenderTextControl.cpp

@@ -124 +124 @@
 {
     // The inner block, if present, always has its direction set to LTR,
-    // so we need to inherit the direction from the element.
+    // so we need to inherit the direction and unicode-bidi style from the element.
     textBlockStyle->setDirection(style()->direction());
+    textBlockStyle->setUnicodeBidi(style()->unicodeBidi());
 
     bool disabled = updateUserModifyProperty(node(), textBlockStyle);