Changeset 91915 in webkit


Ignore:
Timestamp:
Jul 28, 2011 4:42:29 AM (13 years ago)
Author:
rwlbuis@webkit.org
Message:

2011-07-28 Rob Buis <rbuis@rim.com>

REGRESSION (r91125): Google Drawings is broken
https://bugs.webkit.org/show_bug.cgi?id=65257

Reviewed by Darin Adler.

Only consider zero-length path rendering code path when a stroke is defined.

Test: svg/custom/zero-path-square-cap-rendering2.svg

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r91914 r91915  
     12011-07-28  Rob Buis  <rbuis@rim.com>
     2
     3        REGRESSION (r91125): Google Drawings is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=65257
     5
     6        Reviewed by Darin Adler.
     7
     8        * svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
     9        * svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.
     10        * svg/custom/zero-path-square-cap-rendering2.svg: Added.
     11
    1122011-07-22  Martin Robinson  <mrobinson@igalia.com>
    213
  • trunk/Source/WebCore/ChangeLog

    r91914 r91915  
     12011-07-28  Rob Buis  <rbuis@rim.com>
     2
     3        REGRESSION (r91125): Google Drawings is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=65257
     5
     6        Reviewed by Darin Adler.
     7
     8        Only consider zero-length path rendering code path when a stroke is defined.
     9
     10        Test: svg/custom/zero-path-square-cap-rendering2.svg
     11
     12        * rendering/svg/RenderSVGPath.cpp:
     13        (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
     14
    1152011-07-22  Martin Robinson  <mrobinson@igalia.com>
    216
  • trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp

    r91191 r91915  
    156156    // Spec(11.4): Any zero length subpath shall not be stroked if the ‘stroke-linecap’ property has a value of butt
    157157    // but shall be stroked if the ‘stroke-linecap’ property has a value of round or square
    158     return style()->svgStyle()->capStyle() != ButtCap && !m_fillBoundingBox.width() && !m_fillBoundingBox.height();
     158    return style()->svgStyle()->hasStroke() && style()->svgStyle()->capStyle() != ButtCap && !m_fillBoundingBox.width() && !m_fillBoundingBox.height();
    159159}
    160160
Note: See TracChangeset for help on using the changeset viewer.