Changeset 91999 in webkit

Timestamp:

Jul 29, 2011 10:23:39 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Avoid calling animation timer updates while the page is loading
​https://bugs.webkit.org/show_bug.cgi?id=64851

Patch by Zeng Huiqing <​huiqing.zeng@intel.com> on 2011-07-29
Reviewed by Simon Fraser.

There is no need to update the animation timer for a RenderObject that has not yet been inserted into the render tree, or that doesn't have animations. Our tests show that this improves page loading by up to 3x on pages with a large number of transitionable objects.

• page/animation/AnimationController.cpp:

(WebCore::AnimationController::updateAnimations):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/animation/AnimationController.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-29  Zeng Huiqing  <huiqing.zeng@intel.com>
+
+        Avoid calling animation timer updates while the page is loading
+        https://bugs.webkit.org/show_bug.cgi?id=64851
+
+        Reviewed by Simon Fraser.
+
+        There is no need to update the animation timer for a RenderObject that has not yet been inserted into the render tree, or that doesn't have animations. Our tests show that this improves page loading by up to 3x on pages with a large number of transitionable objects.
+
+        * page/animation/AnimationController.cpp:
+        (WebCore::AnimationController::updateAnimations):
+
 2011-07-29  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/page/animation/AnimationController.cpp

@@ -501 +501 @@
     RefPtr<RenderStyle> blendedStyle = rendererAnimations->animate(renderer, oldStyle, newStyle);
 
-    m_data->updateAnimationTimer();
+    if (renderer->parent() || newStyle->animations() || (oldStyle && oldStyle->animations()))
+        m_data->updateAnimationTimer();
 
     if (blendedStyle != newStyle) {